Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Making parameter input components label configurable #5195

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix(editor): Making parameter input components label configurable #5195

merged 1 commit into from
Jan 20, 2023

Conversation

cstuncsik
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jan 18, 2023
@cstuncsik cstuncsik marked this pull request as ready for review January 19, 2023 08:15
alexgrozav
alexgrozav approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@alexgrozav alexgrozav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Could've also used v-bind="label" to not need to update future label params, but I guess it's unlikely to happen.

@cstuncsik cstuncsik merged commit 9ce526e into master Jan 20, 2023
@cstuncsik cstuncsik deleted the pay-35-parameter-labels-are-set-to-small-but branch January 20, 2023 16:07
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Jan 20, 2023
MiloradFilipovic added a commit that referenced this pull request Jan 23, 2023
@MiloradFilipovic
Merge branch 'master' into ado-6-ndv-simplify-credentials
9382331 
* master:
  fix(editor): Making parameter input components label configurable (#5195)
  feat(Google Analytics Node): Overhaul for google analytics node
  fix(Linear Node): Fix issue with single item not being returned (#5193)
  refactor: Update Notion nodes to remove beta from name (#4838)
  refactor(editor): Decouple REST calls from views (no-changelog) (#5202)
  test: Skip some syslog tests (no-changelog) (#5206)
  fix(Notion (Beta) Node): Fix create database page fails if relation param is empty/undefined (#5182)
  fix(core): Fix url in error handelling for the error Trigger (#5201)
  📚 Update CHANGELOG.md and main package.json to 0.212.0
  🔖 Release [email protected]
  ⬆️ Set [email protected] and [email protected] on n8n
  🔖 Release [email protected]
  🔖 Release [email protected]
  fix(core): Revert rule @typescript-eslint/prefer-nullish-coalescing
  feat(core): Add Prometheus metrics for n8n events and api invocations (experimental) (#5177)
@janober
Copy link
Member

janober commented Jan 23, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgrozav alexgrozav alexgrozav approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstuncsik @janober @alexgrozav