refactor: Improve warnings and error messages to users about sharing #4687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
alexgrozav
reviewed
Nov 22, 2022
| @@ -160,7 +160,7 @@ credentialsController.patch( | |||
| userId: req.user.id, | |||
| }); | |||
| throw new ResponseHelper.ResponseError( | |||
| `Credential with ID "${credentialId}" could not be found to be updated.`, | |||
| 'Credential not found to be updated. You can only update credentials owned by you', | |||
There was a problem hiding this comment.
Better wording: Credential to be updated not found
| @@ -218,7 +218,7 @@ credentialsController.delete( | |||
| userId: req.user.id, | |||
| }); | |||
| throw new ResponseHelper.ResponseError( | |||
| `Credential with ID "${credentialId}" could not be found to be deleted.`, | |||
| 'Credential not found to be deleted. You can only removed credentials owned by you', | |||
There was a problem hiding this comment.
Better wording: Credential to be deleted not found
| @@ -140,7 +144,7 @@ EEWorkflowController.post( | |||
| EEWorkflows.validateCredentialPermissionsToUser(newWorkflow, allCredentials); | |||
| } catch (error) { | |||
| throw new ResponseHelper.ResponseError( | |||
| 'The workflow contains credentials that you do not have access to', | |||
| 'The workflow you trying to save contains credentials not shared with you', | |||
There was a problem hiding this comment.
Better wording: The workflow you are trying to save contains credentials that are not shared with you
alexgrozav
approved these changes
Nov 22, 2022
n8n-assistant
bot
added
the
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 22, 2022
* feature/ad-ldap: (22 commits) perf(Code Node): Improve n8n item key validation performance (#4669) feat: Implement runtine check for enterprise features (no-changelog) (#4676) refactor: Consolidate `.prettierignore` patterns (no-changelog) (#4692) refactor: Improve error logging/reporting for `cli` (#4691) feat(editor): Add workflows list status filter (#4690) fix: Expand `nodes-base` formatting validation (no-changelog) (#4689) refactor: Improve warnings and error messages to users about sharing (#4687) (no-changelog) fix: Update subview switch condition (no-changelog) (#4688) refactor: Validate formatting in `nodes-base` (no-changelog) (#4685) feat: Show delete button based on workflow permissions (#4686) feat: Show toast when saving workflow sharing settings (#4684) feat: Add save confirmation modal when leaving sharing modal (#4683) fix: Update workflow title in workflowsById as well (no-changelog) (#4682) feat: Add share button to workflows list (#4681) feat: Add credentials E2E test suite and page object (#4596) fix(core): Use CredentialsOverwrites when testing credentials (#4675) refactor: Adjust credential endpoints permissions (#4656) (no-changelog) fix: Fix settings header text slot (no-changelog) (#4667) feat: Switch owner subview to all subview if has shared resources (#4672) fix(IF Node): Fix "Is Empty" and "Is Not Empty" operation fails for date objects (#4670) ...
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 23, 2022
* master: (35 commits) fix: Remove redundant await in node's api request functions without try/catch (#4639) fix(core): Fix `$items().length` behavior in `executeOnce` mode (#4694) perf(Code Node): Improve n8n item key validation performance (#4669) feat: Implement runtine check for enterprise features (no-changelog) (#4676) refactor: Consolidate `.prettierignore` patterns (no-changelog) (#4692) refactor: Improve error logging/reporting for `cli` (#4691) feat(editor): Add workflows list status filter (#4690) fix: Expand `nodes-base` formatting validation (no-changelog) (#4689) refactor: Improve warnings and error messages to users about sharing (#4687) (no-changelog) fix: Update subview switch condition (no-changelog) (#4688) refactor: Validate formatting in `nodes-base` (no-changelog) (#4685) feat: Show delete button based on workflow permissions (#4686) feat: Show toast when saving workflow sharing settings (#4684) feat: Add save confirmation modal when leaving sharing modal (#4683) fix: Update workflow title in workflowsById as well (no-changelog) (#4682) feat: Add share button to workflows list (#4681) feat: Add credentials E2E test suite and page object (#4596) fix(core): Use CredentialsOverwrites when testing credentials (#4675) refactor: Adjust credential endpoints permissions (#4656) (no-changelog) fix: Fix settings header text slot (no-changelog) (#4667) ... # Conflicts: # packages/editor-ui/src/components/WorkflowCard.vue # packages/editor-ui/src/views/WorkflowsView.vue
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.