Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Show toast when saving workflow sharing settings #4684

Merged
merged 2 commits into from
Nov 22, 2022
Merged

feat: Show toast when saving workflow sharing settings #4684

merged 2 commits into from
Nov 22, 2022

Conversation

alexgrozav
Copy link
Member

Nov-22-2022 13-02-34

@alexgrozav alexgrozav merged commit 6f8d0de into master Nov 22, 2022
@alexgrozav alexgrozav deleted the n8n-5683-show-toast-when-saving-sharing-settings branch November 22, 2022 11:26
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 22, 2022
MiloradFilipovic added a commit that referenced this pull request Nov 22, 2022
@MiloradFilipovic
Merge branch 'feature/ad-ldap' into N8N-5602-form-inputs-updates
881e2c7 
* feature/ad-ldap: (22 commits)
  perf(Code Node): Improve n8n item key validation performance (#4669)
  feat: Implement runtine check for enterprise features (no-changelog) (#4676)
  refactor: Consolidate `.prettierignore` patterns (no-changelog) (#4692)
  refactor: Improve error logging/reporting for `cli` (#4691)
  feat(editor): Add workflows list status filter (#4690)
  fix: Expand `nodes-base` formatting validation (no-changelog) (#4689)
  refactor: Improve warnings and error messages to users about sharing (#4687) (no-changelog)
  fix: Update subview switch condition (no-changelog) (#4688)
  refactor: Validate formatting in `nodes-base` (no-changelog) (#4685)
  feat: Show delete button based on workflow permissions (#4686)
  feat: Show toast when saving workflow sharing settings (#4684)
  feat: Add save confirmation modal when leaving sharing modal (#4683)
  fix: Update workflow title in workflowsById as well (no-changelog) (#4682)
  feat: Add share button to workflows list (#4681)
  feat: Add credentials E2E test suite and page object (#4596)
  fix(core): Use CredentialsOverwrites when testing credentials (#4675)
  refactor: Adjust credential endpoints permissions (#4656) (no-changelog)
  fix: Fix settings header text slot  (no-changelog) (#4667)
  feat: Switch owner subview to all subview if has shared resources (#4672)
  fix(IF Node): Fix "Is Empty" and "Is Not Empty" operation fails for date objects (#4670)
  ...
MiloradFilipovic added a commit that referenced this pull request Nov 23, 2022
@MiloradFilipovic
Merge branch 'master' into n8n-5477-utils-refactor
919af36 
* master: (35 commits)
  fix: Remove redundant await in node's api request functions without try/catch (#4639)
  fix(core): Fix `$items().length` behavior in `executeOnce` mode (#4694)
  perf(Code Node): Improve n8n item key validation performance (#4669)
  feat: Implement runtine check for enterprise features (no-changelog) (#4676)
  refactor: Consolidate `.prettierignore` patterns (no-changelog) (#4692)
  refactor: Improve error logging/reporting for `cli` (#4691)
  feat(editor): Add workflows list status filter (#4690)
  fix: Expand `nodes-base` formatting validation (no-changelog) (#4689)
  refactor: Improve warnings and error messages to users about sharing (#4687) (no-changelog)
  fix: Update subview switch condition (no-changelog) (#4688)
  refactor: Validate formatting in `nodes-base` (no-changelog) (#4685)
  feat: Show delete button based on workflow permissions (#4686)
  feat: Show toast when saving workflow sharing settings (#4684)
  feat: Add save confirmation modal when leaving sharing modal (#4683)
  fix: Update workflow title in workflowsById as well (no-changelog) (#4682)
  feat: Add share button to workflows list (#4681)
  feat: Add credentials E2E test suite and page object (#4596)
  fix(core): Use CredentialsOverwrites when testing credentials (#4675)
  refactor: Adjust credential endpoints permissions (#4656) (no-changelog)
  fix: Fix settings header text slot  (no-changelog) (#4667)
  ...

# Conflicts:
#	packages/editor-ui/src/components/WorkflowCard.vue
#	packages/editor-ui/src/views/WorkflowsView.vue
@janober
Copy link
Member

janober commented Nov 24, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutdmour mutdmour mutdmour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgrozav @janober @mutdmour