refactor(editor): restrict mapping discoverability tooltip showing only on string input

[cstuncsik]

No description provided.

[linear]

N8N-5345

[ivov]

Tested with toggle and no longer triggering there.

[ivov]

Thanks! The empty string default arg is missing.

[cstuncsik]

Done

[ivov]

Question, do you think the i18n signatures should be changed? My reasoning was that having an object as in the original keeps the i18n calls more readable, with labels key and fallback for the args. Above I meant only this change below, allowing us to remove unneeded ?? ''. Sorry if I was unclear.

private dynamicRender(
	{ key, fallback = '' }: { key: string; fallback: string; },
) {
	return this.i18n.te(key) ? this.i18n.t(key).toString() : fallback;
}

[cstuncsik]

No problem

The following is not working, you can't define defaults and types at the same time and with default '' ts infers it as string and will complain about the passed parameter (since in most cases it is optional it can be undefined)

private dynamicRender(
  { key, fallback } = { key: '', fallback: '' },
) {
  return this.i18n.te(key) ? this.i18n.t(key).toString() : fallback;
}

So the only thing we can do is to move ?? '' part into this function

private dynamicRender(
  { key, fallback }: { key: string; fallback: string; },
) {
  return this.i18n.te(key) ? this.i18n.t(key).toString() : fallback ?? '';
}

[janober]

Got released with [email protected]