refactor(editor): Migrate part of the vuex store to pinia #4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d modals to work with pinia stores
# Conflicts: # packages/editor-ui/src/components/ActivationModal.vue # packages/editor-ui/src/components/ImportParameter.vue # packages/editor-ui/src/components/MainHeader/MainHeader.vue # packages/editor-ui/src/components/MainHeader/WorkflowDetails.vue # packages/editor-ui/src/components/MainSidebar.vue # packages/editor-ui/src/components/mixins/mouseSelect.ts # packages/editor-ui/src/components/mixins/nodeBase.ts # packages/editor-ui/src/components/mixins/nodeHelpers.ts # packages/editor-ui/src/modules/settings.ts # packages/editor-ui/src/plugins/i18n/index.ts # packages/editor-ui/src/router.ts # packages/editor-ui/src/views/NodeView.vue
…it. Started updating references.
…part1 # Conflicts: # packages/editor-ui/src/components/ExecutionsView/ExecutionsView.vue # packages/editor-ui/src/views/NodeView.vue
…part1 # Conflicts: # packages/editor-ui/src/components/WorkflowSettings.vue # packages/editor-ui/src/components/mixins/workflowHelpers.ts # packages/editor-ui/src/store.ts # packages/editor-ui/src/views/NodeView.vue
MiloradFilipovic
changed the title
MiloradFilipovic
changed the title
# Conflicts: # packages/editor-ui/src/components/ExecutionsView/ExecutionsInfoAccordion.vue # packages/editor-ui/src/components/ExecutionsView/ExecutionsView.vue # packages/editor-ui/src/components/RunDataTable.vue
…ials update flag when resetting workspace
mutdmour
reviewed
Nov 2, 2022
packages/editor-ui/src/components/MainHeader/ExecutionDetails/ExecutionDetails.vue
Show resolved
Hide resolved
# Conflicts: # packages/editor-ui/src/plugins/i18n/index.ts
mutdmour
reviewed
Nov 4, 2022
| position, | ||
| } as IDataObject, | ||
| } as INodeUpdatePropertiesInformation; | ||
| position: { position }, |
There was a problem hiding this comment.
hmm if this works.. then can you please for other places we change node positions? like in pushDownstreamNodes in NodeView.ts
There was a problem hiding this comment.
Seems to work, but the code looks really weird. Take a look.
Comment on lines
113
to
114
| const token = this.$route.query.token.toString(); | ||
| const userId = this.$route.query.userId.toString(); |
There was a problem hiding this comment.
should not we check here still?
Comment on lines
116
to
117
| const inviterId = this.$route.query.inviterId.toString(); | ||
| const inviteeId = this.$route.query.inviteeId.toString(); |
There was a problem hiding this comment.
should not this be addressed still?
Comment on lines
206
to
210
| const updateInformation = { | ||
| key: this.node.id, | ||
| name: this.node.name, | ||
| value: nodeParameters, | ||
| }; | ||
| } as IUpdateInformation; |
There was a problem hiding this comment.
still needs to be addressed
mutdmour
previously approved these changes
Nov 4, 2022
| const inviterId = this.$route.query.inviterId.toString(); | ||
| const inviteeId = this.$route.query.inviteeId.toString(); | ||
| const inviterId = (!this.$route.query.inviterId || typeof this.$route.query.inviterId !== 'string') ? null : this.$route.query.inviterId; | ||
| const inviteeId = (!this.$route.query.inviteeId || typeof this.$route.query.inviteeId !== 'string') ? null : this.$route.query.inviteeId; |
There was a problem hiding this comment.
this is an edge case.. maybe better to set inviterId and inviteeId as data and so we don't need to check types here.. anyways we should not continue to signup with these values as null
* master: fix(editor): fix themes the monaco editor (no-changelog) (#4521)
MiloradFilipovic
changed the title
mutdmour
approved these changes
Nov 4, 2022
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 4, 2022
* master: refactor(editor): Migrate part of the vuex store to pinia (#4484) fix(editor): fix themes the monaco editor (no-changelog) (#4521) refactor(editor): restrict mapping discoverability tooltip showing only on string input (#4496) 📚 Remove entries from Changelog 📚 Update CHANGELOG.md and main package.json to 0.201.0 🔖 Release [email protected] ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n 🔖 Release [email protected] ⬆️ Set [email protected] and [email protected] on n8n-editor-ui 🔖 Release [email protected] 🔖 Release [email protected] ⬆️ Set [email protected] and [email protected] on n8n-nodes-base 🔖 Release [email protected] ⬆️ Set [email protected] and [email protected] on n8n-node-dev 🔖 Release [email protected] ⬆️ Set [email protected] on n8n-core 🔖 Release [email protected] fix(core): make `deepCopy` backward compatible (#4505) fix(editor): workflow settings link font size change (no-changelog) (#4511) perf(editor): improve array intersection utility function (#4503) # Conflicts: # packages/editor-ui/src/App.vue # packages/editor-ui/src/components/ActivationModal.vue # packages/editor-ui/src/components/NDVDraggablePanels.vue # packages/editor-ui/src/components/NodeSettings.vue # packages/editor-ui/src/components/Sticky.vue # packages/editor-ui/src/components/mixins/workflowHelpers.ts # packages/editor-ui/src/constants.ts # packages/editor-ui/src/plugins/i18n/index.ts # packages/editor-ui/src/views/ChangePasswordView.vue # packages/editor-ui/src/views/NodeView.vue # packages/editor-ui/src/views/SignupView.vue
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N8N-5193