Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Enable import/order for design-system, workflow and @n8n packages #10847

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

tomi
Copy link
Contributor

@tomi tomi commented Sep 17, 2024

Summary

Enable import/order eslint rule for design-system package

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 17, 2024
@tomi tomi force-pushed the enable-import-order-for-design-system branch from 1a405f3 to 96b3742 Compare September 17, 2024 11:12
@tomi tomi changed the title refactor: Enable import/order for design-system refactor: Enable import/order for design-system, workflow and @n8n packages Sep 17, 2024
Copy link

cypress bot commented Sep 18, 2024

n8n    Run #6932

Run Properties:  status check failed Failed #6932  •  git commit c17c7e2cbf: 🌳 upgrade-frontend-dev-tooling 🖥️ browsers:node18.12.0-chrome107 🤖 milorad 🗃...
Project n8n
Branch Review upgrade-frontend-dev-tooling
Run status status check failed Failed #6932
Run duration 03m 59s
Commit git commit c17c7e2cbf: 🌳 upgrade-frontend-dev-tooling 🖥️ browsers:node18.12.0-chrome107 🤖 milorad 🗃...
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 6
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 337
View all changes introduced in this branch ↗︎

Tests for review

Failed  17-sharing.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Sharing > credentials should work between team and personal projects Test Replay Screenshots Video
Credential Usage in Cross Shared Workflows > should only show credentials from the same team project Test Replay Screenshots Video
Failed  39-projects.cy.ts • 4 failed tests

View Output Video

Test Artifacts
Projects > should handle workflows and credentials and menu items Test Replay Screenshots Video
Projects > when starting from scratch > should filter credentials by project ID when creating new workflow or hard reloading an opened workflow Test Replay Screenshots Video
Projects > when starting from scratch > should move resources between projects Test Replay Screenshots Video
Projects > when starting from scratch > should handle viewer role Test Replay Screenshots Video
Failed  233-AI-switch-to-logs-on-error.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  21-community-nodes.cy.ts • 0 failed tests

View Output

Test Artifacts
Failed  42-nps-survey.cy.ts • 0 failed tests

View Output

Test Artifacts

The first 5 failed specs are shown, see all 35 specs in Cypress Cloud.

Flakiness  e2e/45-ai-assistant.cy.ts • 1 flaky test

View Output Video

Test Artifacts
AI Assistant Credential Help > should start credential help from node credential Test Replay Screenshots Video

Copy link
Contributor

✅ All Cypress E2E specs passed

@tomi tomi merged commit 4f0a1a9 into master Sep 18, 2024
33 checks passed
@tomi tomi deleted the enable-import-order-for-design-system branch September 18, 2024 07:19
ivov added a commit that referenced this pull request Sep 18, 2024
@janober
Copy link
Member

janober commented Sep 18, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants