Merge remote-tracking branch 'origin/master' into upgrade-frontend-de…

…v-tooling

.github/workflows/chromatic.yml

@@ -4,19 +4,49 @@ on:
   workflow_dispatch:
   pull_request_review:
     types: [submitted]
-    branches:
-      - 'master'
-    paths:
-      - packages/design-system/**
-      - .github/workflows/chromatic.yml
 
 concurrency:
   group: chromatic-${{ github.event.pull_request.number || github.ref }}
   cancel-in-progress: true
 
 jobs:
+  get-metadata:
+    name: Get Metadata
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out current commit
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+          fetch-depth: 2
+
+      - name: Determine changed files
+        uses: tomi/[email protected]
+        id: changed
+        if: github.event_name == 'pull_request_review'
+        with:
+          filters: |
+            design_system:
+              - packages/design-system/**
+              - .github/workflows/chromatic.yml
+
+    outputs:
+      design_system_files_changed: ${{ steps.changed.outputs.design_system == 'true' }}
+      is_community_pr: ${{ contains(github.event.pull_request.labels.*.name, 'community') }}
+      is_pr_target_master: ${{ github.event.pull_request.base.ref == 'master' }}
+      is_dispatch: ${{ github.event_name == 'workflow_dispatch' }}
+      is_pr_approved: ${{ github.event.review.state == 'approved' }}
+
   chromatic:
-    if: ${{ github.event.review.state == 'approved' && !contains(github.event.pull_request.labels.*.name, 'community') }}
+    needs: [get-metadata]
+    if: |
+      needs.get-metadata.outputs.is_dispatch == 'true' ||
+      (
+       needs.get-metadata.outputs.design_system_files_changed == 'true' &&
+       needs.get-metadata.outputs.is_community_pr == 'false' &&
+       needs.get-metadata.outputs.is_pr_target_master == 'true' &&
+       needs.get-metadata.outputs.is_pr_approved == 'true'
+      )
     runs-on: ubuntu-latest
     steps:
       - uses: actions/[email protected]

.github/workflows/ci-postgres-mysql.yml

@@ -10,8 +10,6 @@ on:
       - .github/workflows/ci-postgres-mysql.yml
   pull_request_review:
     types: [submitted]
-    branches:
-      - 'release/*'
 
 concurrency:
   group: db-${{ github.event.pull_request.number || github.ref }}
@@ -21,6 +19,7 @@ jobs:
   build:
     name: Install & Build
     runs-on: ubuntu-latest
+    if: github.event_name != 'pull_request_review' || startsWith(github.event.pull_request.base.ref, 'release/')
     steps:
       - uses: actions/[email protected]
       - run: corepack enable

.github/workflows/ci-pull-requests.yml

@@ -30,6 +30,9 @@ jobs:
       - name: Build
         run: pnpm build
 
+      - name: Run formatcheck
+        run: pnpm format:check
+
       - name: Run typecheck
         run: pnpm typecheck
 

.github/workflows/e2e-tests-pr.yml

@@ -3,19 +3,51 @@ name: PR E2E
 on:
   pull_request_review:
     types: [submitted]
-    branches:
-      - 'master'
-      - 'release/*'
 
 concurrency:
   group: e2e-${{ github.event.pull_request.number || github.ref }}
   cancel-in-progress: true
 
 jobs:
+  get-metadata:
+    name: Get Metadata
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out current commit
+        uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+          fetch-depth: 2
+
+      - name: Determine changed files
+        uses: tomi/[email protected]
+        id: changed
+        with:
+          filters: |
+            not_ignored:
+              - '!.devcontainer/**'
+              - '!.github/*'
+              - '!.github/scripts/*'
+              - '!.github/workflows/benchmark-*'
+              - '!.github/workflows/check-*'
+              - '!.vscode/**'
+              - '!docker/**'
+              - '!packages/@n8n/benchmark/**'
+              - '!**/*.md'
+          predicate-quantifier: 'every'
+
+    outputs:
+      # The workflow should run when:
+      # - It has changes to files that are not ignored
+      # - It is not a community PR
+      # - It is targeting master or a release branch
+      should_run: ${{ steps.changed.outputs.not_ignored == 'true' && !contains(github.event.pull_request.labels.*.name, 'community') && (github.event.pull_request.base.ref == 'master' || startsWith(github.event.pull_request.base.ref, 'release/')) }}
+
   run-e2e-tests:
     name: E2E [Electron/Node 18]
     uses: ./.github/workflows/e2e-reusable.yml
-    if: ${{ github.event.review.state == 'approved' && !contains(github.event.pull_request.labels.*.name, 'community') }}
+    needs: [get-metadata]
+    if: ${{ github.event.review.state == 'approved' && needs.get-metadata.outputs.should_run == 'true' }}
     with:
       pr_number: ${{ github.event.pull_request.number }}
       user: ${{ github.event.pull_request.user.login || 'PR User' }}
@@ -25,11 +57,11 @@ jobs:
   post-e2e-tests:
     runs-on: ubuntu-latest
     name: E2E [Electron/Node 18] - Checks
-    needs: [run-e2e-tests]
+    needs: [get-metadata, run-e2e-tests]
     if: always()
     steps:
       - name: E2E success comment
-        if: ${{!contains(github.event.pull_request.labels.*.name, 'community') && needs.run-e2e-tests.outputs.tests_passed == 'true' }}
+        if: ${{ needs.get-metadata.outputs.should_run == 'true' && needs.run-e2e-tests.outputs.tests_passed == 'true' }}
         uses: peter-evans/[email protected]
         with:
           issue-number: ${{ github.event.pull_request.number }}

.prettierignore

@@ -7,3 +7,11 @@ packages/nodes-base/nodes/**/test
 packages/cli/templates/form-trigger.handlebars
 cypress/fixtures
 CHANGELOG.md
+.github/pull_request_template.md
+# Ignored for now
+**/*.md
+# Handled by biome
+**/*.ts
+**/*.js
+**/*.json
+**/*.jsonc

.vscode/extensions.json

@@ -1,5 +1,6 @@
 {
 	"recommendations": [
+		"biomejs.biome",
 		"streetsidesoftware.code-spell-checker",
 		"dangmai.workspace-default-settings",
 		"dbaeumer.vscode-eslint",

.vscode/settings.default.json

@@ -1,6 +1,22 @@
 {
 	"editor.defaultFormatter": "esbenp.prettier-vscode",
 	"editor.formatOnSave": true,
+	"[javascript]": {
+		"editor.defaultFormatter": "biomejs.biome"
+	},
+	"[typescript]": {
+		"editor.defaultFormatter": "biomejs.biome"
+	},
+	"[json]": {
+		"editor.defaultFormatter": "biomejs.biome"
+	},
+	"[jsonc]": {
+		"editor.defaultFormatter": "biomejs.biome"
+	},
+	"editor.codeActionsOnSave": {
+		"quickfix.biome": "explicit",
+		"source.organizeImports.biome": "never"
+	},
 	"search.exclude": {
 		"node_modules": true,
 		"dist": true,

biome.jsonc

@@ -0,0 +1,48 @@
+{
+	"$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
+	"vcs": {
+		"clientKind": "git",
+		"enabled": true,
+		"useIgnoreFile": true
+	},
+	"files": {
+		"ignore": [
+			"**/.turbo",
+			"**/coverage",
+			"**/dist",
+			"**/package.json",
+			"**/pnpm-lock.yaml",
+			"**/CHANGELOG.md"
+		]
+	},
+	"formatter": {
+		"enabled": true,
+		"formatWithErrors": false,
+		"indentStyle": "tab",
+		"indentWidth": 2,
+		"lineEnding": "lf",
+		"lineWidth": 100,
+		"attributePosition": "auto",
+		"ignore": [
+			// Handled by prettier
+			"**/*.vue"
+		]
+	},
+	"organizeImports": { "enabled": false },
+	"linter": {
+		"enabled": false
+	},
+	"javascript": {
+		"formatter": {
+			"jsxQuoteStyle": "double",
+			"quoteProperties": "asNeeded",
+			"trailingCommas": "all",
+			"semicolons": "always",
+			"arrowParentheses": "always",
+			"bracketSpacing": true,
+			"bracketSameLine": false,
+			"quoteStyle": "single",
+			"attributePosition": "auto"
+		}
+	}
+}

cypress/biome.jsonc

@@ -0,0 +1,7 @@
+{
+	"$schema": "../node_modules/@biomejs/biome/configuration_schema.json",
+	"extends": ["../biome.jsonc"],
+	"formatter": {
+		"ignore": ["fixtures/**"]
+	}
+}

cypress/e2e/24-ndv-paired-item.cy.ts

@@ -227,7 +227,7 @@ describe('NDV', () => {
 
 		workflowPage.actions.zoomToFit();
 
-		/* prettier-ignore */
+		// biome-ignore format:
 		const PINNED_DATA = [
 			{
 				"id": "abc",
@@ -263,7 +263,6 @@ describe('NDV', () => {
 				]
 			}
 		];
-		/* prettier-ignore */
 		workflowPage.actions.openNode('Get thread details1');
 		ndv.actions.pastePinnedData(PINNED_DATA);
 		ndv.actions.close();

cypress/e2e/6-code-node.cy.ts

@@ -43,7 +43,9 @@ describe('Code node', () => {
 			const getParameter = () => ndv.getters.parameterInput('jsCode').should('be.visible');
 			const getEditor = () => getParameter().find('.cm-content').should('exist');
 
-			getEditor().type('{selectall}').paste(`$input.itemMatching()
+			getEditor()
+				.type('{selectall}')
+				.paste(`$input.itemMatching()
 $input.item
 $('When clicking ‘Test workflow’').item
 $input.first(1)
@@ -68,7 +70,9 @@ return
 
 			ndv.getters.parameterInput('mode').click();
 			ndv.actions.selectOptionInParameterDropdown('mode', 'Run Once for Each Item');
-			getEditor().type('{selectall}').paste(`$input.itemMatching()
+			getEditor()
+				.type('{selectall}')
+				.paste(`$input.itemMatching()
 $input.all()
 $input.first()
 $input.item()

cypress/package.json

@@ -7,7 +7,8 @@
     "test:e2e:ui": "scripts/run-e2e.js ui",
     "test:e2e:dev": "scripts/run-e2e.js dev",
     "test:e2e:all": "scripts/run-e2e.js all",
-    "format": "prettier --write . --ignore-path ../.prettierignore",
+    "format": "biome format --write .",
+    "format:check": "biome ci .",
     "lint": "eslint . --quiet",
     "lintfix": "eslint . --fix",
     "develop": "cd ..; pnpm dev",

lefthook.yml

@@ -0,0 +1,10 @@
+pre-commit:
+  commands:
+    biome_check:
+      glob: 'packages/**/*.{js,ts,json}'
+      run: ./node_modules/.bin/biome check --write --no-errors-on-unmatched --files-ignore-unknown=true --colors=off {staged_files}
+      stage_fixed: true
+    prettier_check:
+      glob: 'packages/**/*.{vue,yml,md}'
+      run: ./node_modules/.bin/prettier --write --ignore-unknown --no-error-on-unmatched-pattern {staged_files}
+      stage_fixed: true

n8n.code-workspace

@@ -1,7 +1,7 @@
 {
 	"folders": [
 		{
-			"path": ".",
-		},
-	],
+			"path": "."
+		}
+	]
 }

package.json

@@ -8,6 +8,7 @@
   },
   "packageManager": "[email protected]",
   "scripts": {
+    "prepare": "lefthook install",
     "preinstall": "node scripts/block-npm-install.js",
     "build": "turbo run build",
     "build:backend": "turbo run build:backend",
@@ -19,6 +20,7 @@
     "clean": "turbo run clean --parallel",
     "reset": "node scripts/ensure-zx.mjs && zx scripts/reset.mjs",
     "format": "turbo run format && node scripts/format.mjs",
+    "format:check": "turbo run format:check",
     "lint": "turbo run lint",
     "lintfix": "turbo run lintfix",
     "lint:backend": "turbo run lint:backend",
@@ -38,6 +40,7 @@
     "worker": "./packages/cli/bin/n8n worker"
   },
   "devDependencies": {
+    "@biomejs/biome": "^1.9.0",
     "@n8n_io/eslint-config": "workspace:*",
     "@types/jest": "^29.5.3",
     "@types/supertest": "^6.0.2",
@@ -46,6 +49,7 @@
     "jest-expect-message": "^1.1.3",
     "jest-mock": "^29.6.2",
     "jest-mock-extended": "^3.0.4",
+    "lefthook": "^1.7.15",
     "nock": "^13.3.2",
     "nodemon": "^3.0.1",
     "p-limit": "^3.1.0",

packages/@n8n/api-types/package.json

@@ -6,7 +6,8 @@
     "dev": "pnpm watch",
     "typecheck": "tsc --noEmit",
     "build": "tsc -p tsconfig.build.json",
-    "format": "prettier --write . --ignore-path ../../../.prettierignore",
+    "format": "biome format --write .",
+    "format:check": "biome ci .",
     "lint": "eslint .",
     "lintfix": "eslint . --fix",
     "watch": "tsc -p tsconfig.build.json --watch",

packages/@n8n/benchmark/biome.jsonc

@@ -0,0 +1,7 @@
+{
+	"$schema": "../node_modules/@biomejs/biome/configuration_schema.json",
+	"extends": ["../../../biome.jsonc"],
+	"files": {
+		"ignore": ["scripts/mock-api/**"]
+	}
+}

packages/@n8n/benchmark/package.json

@@ -5,6 +5,8 @@
   "main": "dist/index",
   "scripts": {
     "build": "tsc -p tsconfig.build.json && tsc-alias -p tsconfig.build.json",
+    "format": "biome format --write .",
+    "format:check": "biome ci .",
     "lint": "eslint .",
     "lintfix": "eslint . --fix",
     "start": "./bin/n8n-benchmark",

packages/@n8n/chat/package.json

@@ -12,7 +12,8 @@
     "typecheck": "vue-tsc --noEmit",
     "lint": "eslint . --ext .js,.ts,.vue --quiet",
     "lintfix": "eslint . --ext .js,.ts,.vue --fix",
-    "format": "prettier --write src/",
+    "format": "biome format --write src .storybook && prettier --write src/ --ignore-path ../../.prettierignore",
+    "format:check": "biome ci src .storybook && prettier --check src/ --ignore-path ../../.prettierignore",
     "storybook": "storybook dev -p 6006 --no-open",
     "build:storybook": "storybook build"
   },