Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add missing control button events to new canvas (no-changelog) #10471

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

alexgrozav
Copy link
Member

Summary

A small mishap in one of Friday's PRs.

Related Linear tickets, Github issues, and Community forum posts

N/A

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Aug 19, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 19, 2024
Copy link
Contributor

@tomi tomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@@ -269,7 +269,8 @@ function emitWithLastSelectedNode(emitFn: (id: string) => void) {
* View
*/

const zoom = ref(1);
const defaultZoom = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change was already in the other PR?

Copy link

cypress bot commented Aug 19, 2024



Test summary

402 0 0 0Flakiness 1


Run details

Project n8n
Status Passed
Commit 4efeb44
Started Aug 19, 2024 12:18 PM
Ended Aug 19, 2024 12:23 PM
Duration 04:47 💡
OS Linux Debian -
Browser Electron 118

View run in Cypress Cloud ➡️


Flakiness

e2e/17-sharing.cy.ts Flakiness
1 Credential Usage in Cross Shared Workflows > should only show credentials in their personal project for members

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit fadb5c9 into master Aug 19, 2024
27 checks passed
@alexgrozav alexgrozav deleted the n8n-7576-bottom-left-buttons-events branch August 19, 2024 14:05
MiloradFilipovic added a commit that referenced this pull request Aug 19, 2024
* master:
  fix(editor): Fix edge button background color in dark mode in new canvas (no-changelog) (#10475)
  feat(editor): Add old execution status rendering in new canvas (no-changelog) (#10473)
  feat(editor): Update cursor behaviour in new canvas (no-changelog) (#10472)
  fix(editor): Add missing control button events to new canvas (no-changelog) (#10471)
  fix: Show input names when node has multiple inputs (#10434)
  fix(editor): Adjust default zoom level in new canvas (no-changelog) (#10469)
  fix(Read/Write Files from Disk Node): Better error handling when file name missing (no-changelog) (#10463)
  fix: Remove unimplemented Postgres credentials options (#10461)
  fix(Invoice Ninja Node): Fix payment types (#10462)
@janober
Copy link
Member

janober commented Aug 21, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants