fix(core): Make execution and its data creation atomic #10276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executions and their data are inserted in two separate insert statements. Before this PR, this wasn't done in a transaction, which could cause executions to be created without execution data. This caused issues like the one fixed in #9903.
netroy
reviewed
Aug 1, 2024
netroy
reviewed
Aug 1, 2024
packages/cli/src/databases/repositories/execution.repository.ts
Outdated
Show resolved
Hide resolved
n8n-assistant
bot
added
core
netroy
requested changes
Aug 2, 2024
Comment on lines
-77
to
-79
| if (executionId === undefined) { | ||
| throw new ApplicationError('There was an issue assigning an execution id to the execution'); | ||
| } |
There was a problem hiding this comment.
this check has never made sense. the only reason the types here suggest that executionId could be missing is because we are reusing the variable. This code will never run, since if creating an execution fails, we'll have an unhandled error.
There was a problem hiding this comment.
Exactly. That's why I changed it to an assert so it satisfies the type system
packages/cli/src/databases/repositories/execution.repository.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/databases/repositories/executionData.repository.ts
Outdated
Show resolved
Hide resolved
…d-its-data-in-atomic-transaction
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Aug 2, 2024
* master: refactor(core): Clean up event relays (no-changelog) (#10284) fix(editor): Fix execution retry button (#10275) feat(core): Show sub-node error on the logs pane. Open logs pane on sub-node error (#10248) refactor(core): Move instanceRole to InstanceSettings (no-changelog) (#10242) feat(core): Allow filtering executions and users by project in Public API (#10250) fix(core): Make execution and its data creation atomic (#10276) refactor(core): Mark schema env vars used by cloud hooks (no-changelog) (#10283) ci: Fix DB tests (no-changelog) (#10282) feat(core): Support create, delete, edit role for users in Public API (#10279) refactor(core): Decouple post workflow execute event from internal hooks (no-changelog) (#10280) feat(core): Allow transferring credentials in Public API (#10259) feat(core): Support create, read, update, delete projects in Public API (#10269) ci: Introduce lint rule `no-type-unsafe-event-emitter` (no-changelog) (#10254) fix(core): Surface enterprise trial error message (#10267) fix(editor): Enable moving resources only if team projects are available by the license (#10271) fix(core): Upgrade tournament to address some XSS vulnerabilities (#10277) # Conflicts: # packages/cli/src/Server.ts
1 task
Merged
|
Got released with |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Executions and their data are inserted in two separate insert statements. Before this PR, this wasn't done in a transaction, which could cause executions to be created without execution data. This caused issues like the one fixed in #9903.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)