Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Notion Node): Version fix #6531

Conversation

michael-radency
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Jun 23, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (e152cfe) 28.72% compared to head (a0833ac) 28.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6531      +/-   ##
==========================================
- Coverage   28.72%   28.65%   -0.07%     
==========================================
  Files        3000     3000              
  Lines      186302   186299       -3     
  Branches    20600    20598       -2     
==========================================
- Hits        53517    53387     -130     
- Misses     131978   132104     +126     
- Partials      807      808       +1     
Impacted Files Coverage Δ
...ges/nodes-base/nodes/Notion/DatabaseDescription.ts 0.00% <ø> (ø)
...nodes-base/nodes/Notion/DatabasePageDescription.ts 0.00% <ø> (ø)
...ckages/nodes-base/nodes/Notion/GenericFunctions.ts 0.00% <ø> (ø)
...ackages/nodes-base/nodes/Notion/PageDescription.ts 0.00% <ø> (ø)
...s/nodes-base/nodes/Notion/v1/VersionDescription.ts 0.00% <ø> (ø)
...ckages/nodes-base/nodes/Notion/v2/NotionV2.node.ts 0.00% <ø> (ø)
...s/nodes-base/nodes/Notion/v2/VersionDescription.ts 0.00% <ø> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cypress
Copy link

cypress bot commented Jun 23, 2023

Passing run #1308 ↗︎

0 227 0 0 Flakiness 0

Details:

🌳 node-568-notion-node-ignores-the-version-for-the-descriptions 🖥️ browsers:no...
Project: n8n Commit: a0833acc3a
Status: Passed Duration: 07:33 💡
Started: Jun 23, 2023 10:35 AM Ended: Jun 23, 2023 10:43 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 38dc784 into master Jun 23, 2023
@michael-radency michael-radency deleted the node-568-notion-node-ignores-the-version-for-the-descriptions branch June 23, 2023 11:21
netroy pushed a commit that referenced this pull request Jun 27, 2023
netroy added a commit to netroy/n8n that referenced this pull request Jun 27, 2023
# [1.0.0](https://github.com/netroy/n8n/compare/[email protected]@1.0.0)
(2023-06-27)


### Bug Fixes

* **core:** Add empty credential value marker to show empty pw field
([n8n-io#6532](https://github.com/netroy/n8n/issues/6532))
([9294e2d](9294e2d))
* **core:** All migrations should run in a transaction
([n8n-io#6519](https://github.com/netroy/n8n/issues/6519))
([e152cfe](e152cfe))
* **core:** Rename to credential_stubs and variable_stubs.json
([n8n-io#6528](https://github.com/netroy/n8n/issues/6528))
([b06462f](b06462f))
* **Edit Image Node:** Fix transparent operation
([n8n-io#6513](https://github.com/netroy/n8n/issues/6513))
([4a4bcbc](4a4bcbc))
* **editor:** Add default author name and email to source control
settings ([n8n-io#6543](https://github.com/netroy/n8n/issues/6543))
([e1a02c7](e1a02c7))
* **editor:** Change default branchColor and remove label
([n8n-io#6541](https://github.com/netroy/n8n/issues/6541))
([186271e](186271e))
* **Google Drive Node:** URL parsing
([n8n-io#6527](https://github.com/netroy/n8n/issues/6527))
([d9ed0b3](d9ed0b3))
* **Google Sheets Node:** Incorrect read of 0 and false
([n8n-io#6525](https://github.com/netroy/n8n/issues/6525))
([806d134](806d134))
* **Merge Node:** Enrich input 2 fix
([n8n-io#6526](https://github.com/netroy/n8n/issues/6526))
([c82c7f1](c82c7f1))
* **Notion Node:** Version fix
([n8n-io#6531](https://github.com/netroy/n8n/issues/6531))
([38dc784](38dc784))


### Features

* Add missing input panels to some trigger nodes
([n8n-io#6518](https://github.com/netroy/n8n/issues/6518))
([fdf8a42](fdf8a42))
* **editor:** Prevent saving of workflow when canvas is loading
([n8n-io#6497](https://github.com/netroy/n8n/issues/6497))
([f89ef83](f89ef83))
* **editor:** SQL editor overhaul
([n8n-io#6282](https://github.com/netroy/n8n/issues/6282))
([beedfb6](beedfb6))
* **Google Drive Node:** Overhaul
([n8n-io#5941](https://github.com/netroy/n8n/issues/5941))
([d70a1cb](d70a1cb))
* **HTTP Request Node:** Notice about dev console
([n8n-io#6516](https://github.com/netroy/n8n/issues/6516))
([d431117](d431117))
* **Matrix Node:** Allow setting filename if the binary data has none
([n8n-io#6536](https://github.com/netroy/n8n/issues/6536))
([8b76e98](8b76e98))

Co-authored-by: netroy <[email protected]>
This was referenced Jun 27, 2023
netroy pushed a commit that referenced this pull request Jul 5, 2023
This was referenced Jul 5, 2023
@janober
Copy link
Member

janober commented Jul 5, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants