perf(editor): improve array intersection utility function #4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
OlegIvaniv
approved these changes
Nov 2, 2022
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 4, 2022
* master: refactor(editor): Migrate part of the vuex store to pinia (#4484) fix(editor): fix themes the monaco editor (no-changelog) (#4521) refactor(editor): restrict mapping discoverability tooltip showing only on string input (#4496) 📚 Remove entries from Changelog 📚 Update CHANGELOG.md and main package.json to 0.201.0 🔖 Release [email protected] ⬆️ Set [email protected], [email protected], [email protected] and [email protected] on n8n 🔖 Release [email protected] ⬆️ Set [email protected] and [email protected] on n8n-editor-ui 🔖 Release [email protected] 🔖 Release [email protected] ⬆️ Set [email protected] and [email protected] on n8n-nodes-base 🔖 Release [email protected] ⬆️ Set [email protected] and [email protected] on n8n-node-dev 🔖 Release [email protected] ⬆️ Set [email protected] on n8n-core 🔖 Release [email protected] fix(core): make `deepCopy` backward compatible (#4505) fix(editor): workflow settings link font size change (no-changelog) (#4511) perf(editor): improve array intersection utility function (#4503) # Conflicts: # packages/editor-ui/src/App.vue # packages/editor-ui/src/components/ActivationModal.vue # packages/editor-ui/src/components/NDVDraggablePanels.vue # packages/editor-ui/src/components/NodeSettings.vue # packages/editor-ui/src/components/Sticky.vue # packages/editor-ui/src/components/mixins/workflowHelpers.ts # packages/editor-ui/src/constants.ts # packages/editor-ui/src/plugins/i18n/index.ts # packages/editor-ui/src/views/ChangePasswordView.vue # packages/editor-ui/src/views/NodeView.vue # packages/editor-ui/src/views/SignupView.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with 3 versions of custom functions + lodash + Ramda
See the test results in the screenshot, it is worth having the one that can accept any number of arrays, it's just slightly slower than the other that can take only 2 args