adds ability to purge when images in container are broken #11
Conversation
| if purge: | ||
| url = self.registry.replace("https://", '') + "/" + repo + ":" + tag | ||
| call(["docker", "tag", "busybox:latest", url]) | ||
| call(["doicker", "push", url]) |
There was a problem hiding this comment.
Please fix typo
| call(["doicker", "push", url]) | |
| call(["docker", "push", url]) |
|
@orangewolf do you have ideas why it happens? it has happened for me too in the past, when i excessively ran delete from gitlab ui. but i haven't noticed these 0 byte errors for several months. yet i have now cleanup automation in place and run registry-garbage-collect. or perhaps gitlab fixed something? |
| @@ -76,22 +76,31 @@ def get_digest(self, repo, tag): | |||
| response = requests.head(self.registry + path, headers=headers, verify=self.requests_verify) | |||
| return response.headers["Docker-Content-Digest"] | |||
|
|
|||
| def delete_image(self, repo, tag): | |||
| def delete_image(self, repo, tag, purge): | |||
There was a problem hiding this comment.
please add default value for purge, making it api compatible and having the parameter optiona.
| logging.error(response.text) | ||
|
|
||
| counter = 0 | ||
| while counter < 2: |
There was a problem hiding this comment.
yuk. perhaps add another method to the class delete_with_purge, instead of making original delete method such ugliness?
There was a problem hiding this comment.
i even think such logic should not be in this class... rather find problematic images/tags and fix them elsewise. some new script using same class?
| logging.error(response.text) | ||
|
|
||
| counter = 0 | ||
| while counter < 2: |
There was a problem hiding this comment.
i even think such logic should not be in this class... rather find problematic images/tags and fix them elsewise. some new script using same class?
|
I agree with @glensc - you need to check the return value of the delete_image function and make the logic in |
| except: | ||
| if purge: | ||
| url = self.registry.replace("https://", '') + "/" + repo + ":" + tag | ||
| call(["docker", "tag", "busybox:latest", url]) |
There was a problem hiding this comment.
docker has builtin image named scratch, which can be used in Dockerfile. unfortunately, it's not pullable.
but at some point I created smallest scratch image that returns exit 0:
docker pull glen/scratch
so it's 222 bytes compressed
|
thank you for the great feedback. I won't have cycles to digest and respond until Friday, but I will pick it back up then. |
|
@orangewolf which Friday? :) |
we had a bunch of registries with 0 length or otherwise undeleteable tags in them. We hacked around this by pushing a small image to those tags and then re-running the delete.