-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support ESLint 7.x #7
Conversation
12f6411
to
f1f2ba5
Compare
66dbccd
to
184f159
Compare
@mysticatea I'm not seeing what's going wrong here, so any help getting this landed would be awesome! |
You cannot use bash scripts on Windows. |
@mysticatea Any idea how I could resolve this? |
98f48c7
to
6fac4cb
Compare
@mysticatea I think this one's ready to be merged. Just like |
@mysticatea This is the last thing blocking the release of Create React App v4 so if there's anything we can do to help get this merged and released please let me know. |
@iansu It just needs to be merged. |
Why is this a blocker for anything? It adds a peer dep where there was none, and bumps a dependency which is within semver range. The rest of the changes seems internal to me |
Ping @mysticatea This one can be merged 🙂 |
1227e61
to
162afdb
Compare
@mysticatea Friendly reminder that this one can be merged 🙂 |
162afdb
to
2a0b3d6
Compare
@mysticatea Could you please merge this PR? |
2a0b3d6
to
e0ef067
Compare
Hi @mdjermanovic could we have this PR merged? Thanks! |
Bueller? ;-) |
BREAKING CHANGE: Requires Node@>=10.x
I apologize for my lack of response. For a long time, I had been away from OSS activities for personal reasons. This package has been used in ESLint core, so I thought we didn't need to do anything in order to support ESLint 7. I merged this PR as upgrading dependencies and dropping old Node.js versions. |
Thanks for merging this one @mysticatea! 👊 |
ESLint v7.0.0 is released 🎉
(dev)Dependencies should be compatible with ESLint 7 too before we can merge this one:
@mysticatea/eslint-plugin
(Support ESLint 7.x eslint-plugin#28)BREAKING CHANGE: Requires Node@>=10.x
Closes #6