Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint 7.x #29

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

@MichaelDeBoey MichaelDeBoey force-pushed the eslint-7 branch 2 times, most recently from 8297704 to 724971a Compare May 16, 2020 16:34
@dimitropoulos
Copy link

I'll note that typescript-eslint just released 3.0.0 with eslint 7 support

https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0

@eddiemonge
Copy link

@MichaelDeBoey there is a circular dependency of waiting here:

  • eslint-plugin-eslint-plugin is waiting for eslint-plugin-node
  • This is also directly waiting on eslint-plugin-node

eslint-plugin-node, however is waiting for eslint-utils which is waiting for this PR.

This will never be completed according to that logic

@MichaelDeBoey
Copy link
Author

@eddiemonge The circular dependency will be resolved once eslint-utils is merged without updating @mysticatea/eslint-plugin, like I explained in mysticatea/eslint-utils#7 (comment) 🙂

@MichaelDeBoey
Copy link
Author

@mysticatea Tests are failing because rules are missing in configs.

I'll add them, but I think it would be good if you check them out in order to make sure it's the correct config.

@MichaelDeBoey MichaelDeBoey force-pushed the eslint-7 branch 2 times, most recently from d22c43f to aeea4bb Compare August 22, 2021 23:00
@MichaelDeBoey MichaelDeBoey marked this pull request as ready for review August 22, 2021 23:00
@MichaelDeBoey MichaelDeBoey force-pushed the eslint-7 branch 4 times, most recently from aa0379b to addbfd5 Compare August 23, 2021 00:27
@MichaelDeBoey MichaelDeBoey changed the title feat: Support ESLint 7.x feat: support ESLint 7.x Aug 28, 2021
@MichaelDeBoey
Copy link
Author

MichaelDeBoey commented Oct 18, 2022

For people watching this PR: we've already started with our own fork in order to not hold the wider community back anymore: https://github.com/eslint-community/eslint-plugin-mysticatea

@mysticatea We would still love to move the original repo to the new https://github.com/eslint-community though.


This PR is released in @eslint-community/eslint-plugin-mysticatea v15.1.0
https://github.com/eslint-community/eslint-plugin-mysticatea/releases/tag/v15.1.0

@dimitropoulos
Copy link

too bad it had to come to that, but thank you for putting in the effort to get this unblocked!

I'm sure Toru is just busy. Only so many hours in the day :)

@MichaelDeBoey
Copy link
Author

@dimitropoulos Yeah we still would like to move the original repo to the new @eslint-community org & merge all changes here

I respect @mysticatea is busy, but he hasn't responded to any of our messages in a very long time & we don't want to hold back the wider community anymore, so that's why we already started with our own fork.
Once the original repo is moved, we'd be happy to take the time to merge all pending PRs & release them of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint 7.x
8 participants