-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1570 Newsletter section in front-page #1601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if I over-simplified this section's design
No, absolutely bang on!
I included two options
Logo version 👍
In both cases, I tried to play with the vertical spacing
Yeah, looks great – just want to get the phrasing right and then any minor tweaks needed to accommodate it, but it's perfect in principle 🙌
<img class="newsletter-signup__image" src="<%= image_path('logo-mysociety-black') %>" alt="mySociety logo" width="250px" height="53px"/> | ||
<h2 class="newsletter-signup__title"><%= _("Keep up with what we're doing") %></h2> | ||
<p class="newsletter-signup__subtitle">News on Transparency, Democracy, Community Climate and more…</p> | ||
<a class="button" href="https://www.mysociety.org/subscribe/">Sign up</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The button text might be clearer as "Subscribe to our newsletters"
<div class="newsletter-signup" id="newsletter-signup"> | ||
<img class="newsletter-signup__image" src="<%= image_path('logo-mysociety-black') %>" alt="mySociety logo" width="250px" height="53px"/> | ||
<h2 class="newsletter-signup__title"><%= _("Keep up with what we're doing") %></h2> | ||
<p class="newsletter-signup__subtitle">News on Transparency, Democracy, Community Climate and more…</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing comma after "Community"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add a tiny bit of explanation of mySociety – a one liner.
https://www.whatdotheyknow.com/help/credits has:
WhatDoTheyKnow is a project of mySociety, a UK organisation. mySociety builds websites that empower citizens to hold authorities to account.
"hold to account" is a bit old language now, I think.
https://www.mysociety.org/about has:
mySociety is a not for profit group pioneering the use of online technologies to empower citizens to take their first steps towards greater civic participation.
We help people be active citizens with technology, research and data that individuals, journalists, and civil society can use, openly and for free.
We could condense that down to something like:
WhatDoTheyKnow is a project of mySociety, a not for profit that creates technology, research and data to empower citizens to take their first steps towards greater civic participation.
@MyfanwyNixon how's this from a phrasing POV?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @garethrees glad you like it =)
I think we should try to condense the first and second paragraph, because it feels a bit disjoint in terms of topics:
- First we have a mySociety logo [mySociety]
- Second we have a title that hints about a newsletter [Newsletter]
- But then we talk about mySociety [mySociety]
- Finally we are back at the newsletter again. [Newsletter]
So it feels a bit disjoint. I'm sure @MyfanwyNixon can give us some her magic =)
I changed her the button so it's more self explanatory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, agree the phrasing being a bit jumbled. I think it's roughly the right information to convey, just needs some finesse.
10c40b5
to
1972b32
Compare
Relevant issue(s)
Fixes: #1570
Couple of notes
I'm unsure if I over-simplified this section's design, but I included two options:
Preview Option 1
Preview Option 2
Mobile
Let me know if you have any feedback =) or you have something else in mind.