Update APT formats supported operating systems #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
reviewed
Dec 4, 2023
gbp
reviewed
Dec 4, 2023
gbp
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Line 683 in 2ff5594
Is generating a warning on Bookworm: chown: warning: '.' should be ':': ‘alaveteli.alaveteli’
gbp
reviewed
Dec 4, 2023
gbp
approved these changes
Dec 5, 2023
Rather than exiting altogether if we don't support a particular distro, just print a notice message and continue. See: #87
Add support for Jammy and Bookworm, remove support for Stretch, Xenial and Bionic plus some traces of even older versions. See: #87
This updates our APT source definitions to use the newer deb882 format and renames `/etc/apt/sources.list` to `/etc/apt/sources.list.dist` if it exists to avoid duplicate warnings when running commands. In addition, this also removes the use of `apt-key` in favour of storing the signing key for our repository in `/etc/apt/keyrings` (which will be created if this doesn't exist) and pointing at that via `Signed-By` in the sources, removing deprecation warnings from `apt-key`. See: #87
Long ago, this became standard to allow for the use of `.` in group names. As of more recent distributions this has started to generate warnings. See: #87
sagepe
force-pushed
the
supported-apt-distros
branch
from
21355ac to
caadeeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes support for Stretch, Xenial and Bionic and adds support for Jammy and Bullseye.
It also updates the format used for APT source definitions to use the newer deb882 format, used by default in Bookworm and supported on the older systems, and at the same time removes the use of
apt-keyfor managing signing keys as this is deprecated.Fixes #87