Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script should warn rather than error for unsupported OS when setting up APT repositories #87

Closed
sagepe opened this issue Nov 6, 2023 · 3 comments · Fixed by #88
Assignees

Comments

@sagepe
Copy link
Member

sagepe commented Nov 6, 2023

This is more friendly for re-users who might want to test using an OS we haven't formally added support for.

@gbp
Copy link
Member

gbp commented Nov 6, 2023

Would be good for mysociety/alaveteli#6342

@sagepe sagepe self-assigned this Dec 4, 2023
@sagepe
Copy link
Member Author

sagepe commented Dec 4, 2023

Im going to add Bookworm and Jammy and potentially remove Stretch, Xenial and Bionic at the same time.

@sagepe
Copy link
Member Author

sagepe commented Dec 4, 2023

I'm also going to switch the source to the newer deb882 format, as this is supported on all the distros we now care about.

This includes removing the call to apt-key, which is deprecated, in place of storing the key in the filesystem and using Signed-By: in the sources configuration.

sagepe added a commit that referenced this issue Dec 4, 2023
Rather than exiting altogether if we don't support a particular distro,
just print a notice message and continue.

See: #87
sagepe added a commit that referenced this issue Dec 4, 2023
Add support for Jammy and Bookworm, remove support for Stretch, Xenial
and Bionic.

See: #87
sagepe added a commit that referenced this issue Dec 4, 2023
This updates our APT source definitions to use the newer deb882 format.
In addition, this also removes the use of `apt-key` in favour of storing
the signing key for our repository in `/etc/apt/keyrings` (which will be
created if this doesn't exist) and pointing at that via `Signed-By` in
the sources, removing deprecation warnings from `apt-key`.

See: #87
sagepe added a commit that referenced this issue Dec 5, 2023
Rather than exiting altogether if we don't support a particular distro,
just print a notice message and continue.

See: #87
sagepe added a commit that referenced this issue Dec 5, 2023
Add support for Jammy and Bookworm, remove support for Stretch, Xenial
and Bionic plus some traces of even older versions.

See: #87
sagepe added a commit that referenced this issue Dec 5, 2023
This updates our APT source definitions to use the newer deb882 format
and renames `/etc/apt/sources.list` to `/etc/apt/sources.list.dist` if it
exists to avoid duplicate warnings when running commands.

In addition, this also removes the use of `apt-key` in favour of storing
the signing key for our repository in `/etc/apt/keyrings` (which will be
created if this doesn't exist) and pointing at that via `Signed-By` in
the sources, removing deprecation warnings from `apt-key`.

See: #87
sagepe added a commit that referenced this issue Dec 5, 2023
Long ago, this became standard to allow for the use of `.` in group
names. As of more recent distributions this has started to generate
warnings.

See: #87
@sagepe sagepe closed this as completed in #88 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants