[#7254] Remove PublicBody#notes #7269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
force-pushed
the
7254-remove-legacy-notes
branch
2 times, most recently
from
359b4c6 to
3171a97
Compare
gbp
force-pushed
the
7254-remove-legacy-notes
branch
2 times, most recently
from
765eca4 to
9e18843
Compare
garethrees
reviewed
Jan 27, 2023
gbp
force-pushed
the
7254-remove-legacy-notes
branch
from
9e18843 to
dd24689
Compare
|
Should drop |
This has been replace by a separate Note model. Searching of public bodies by their note content on `/body/list/all` is not possible due to the complex nature of the SQL query. A spec has been disabled due it now failing without the old notes column. This has been broken on WDTK for months without being noticed. Fixes #7254
gbp
force-pushed
the
7254-remove-legacy-notes
branch
from
dd24689 to
913ef20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Requires #6647
Fixes #7254
What does this do?
Remove
PublicBody#notesWhy was this needed?
This has been replace by a separate Note model.
Notes to reviewer
Had wanted to use Factories over Fixtures for notes but too many specs needed updates and this wasn't really the right time to switch.
It seems the searching of public bodies by their note content on
/body/list/allisn't working which is why a spec has been disabled. Will open an issue to restore this functionality.