Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PublicBody#notes column and associated legacy code #7254

Closed
garethrees opened this issue Aug 30, 2022 · 0 comments · Fixed by #7269
Closed

Drop PublicBody#notes column and associated legacy code #7254

garethrees opened this issue Aug 30, 2022 · 0 comments · Fixed by #7269
Milestone
Generalised Notes

Comments

@garethrees
Copy link
Member

No description provided.

@garethrees garethrees added this to the Generalised Notes milestone Aug 30, 2022
gbp added a commit that referenced this issue Sep 2, 2022
@gbp
Remove PublicBody#notes
2e94944 
This has been replace by a separate Note model.

Fixes #7254
@gbp gbp mentioned this issue Sep 2, 2022
Merged
gbp added a commit that referenced this issue Jan 5, 2023
@gbp
Remove PublicBody#notes
359b4c6 
This has been replace by a separate Note model.

Fixes #7254
gbp added a commit that referenced this issue Jan 6, 2023
@gbp
Remove PublicBody#notes
3171a97 
This has been replace by a separate Note model.

Fixes #7254
gbp added a commit that referenced this issue Jan 26, 2023
@gbp
Remove PublicBody#notes
765eca4 
This has been replace by a separate Note model.

Fixes #7254
gbp added a commit that referenced this issue Jan 27, 2023
@gbp
Remove PublicBody#notes
9e18843 
This has been replace by a separate Note model.

Fixes #7254
gbp added a commit that referenced this issue Jan 27, 2023
@gbp
Remove PublicBody#notes
dd24689 
This has been replace by a separate Note model.

Searching of public bodies by their note content on `/body/list/all` is
not possible due to the complex nature of the SQL query. A spec has been
disabled due it now failing without the old notes column.

This has been broken on WDTK for months without being noticed.

Fixes #7254
@gbp gbp closed this as completed in 913ef20 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Generalised Notes
Development

Successfully merging a pull request may close this issue.

[#7254] Remove PublicBody#notes mysociety/alaveteli
1 participant
@garethrees