[WIP] Add action menu to footer of request thread #3671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I think we're always going to want to do this, so make it global.
mysociety-pusher
force-pushed
the
3649-dup-action-menu
branch
from
9c94fd9 to
07b7231
Compare
garethrees
commented
Jan 11, 2017
| @@ -270,6 +270,8 @@ a.track-request-action { | |||
| align-items: stretch; | |||
| } | |||
|
|
|||
| float: none; | |||
There was a problem hiding this comment.
Without this the eu promo overlaps the action menu. I expect this is coming from either the grid-column or the flexbox, but I don't really understand the consequences of not having this floating.
1 similar comment
mysociety-pusher
force-pushed
the
3649-dup-action-menu
branch
from
997d8b1 to
e168722
Compare
Authority action bar is now more consistent in appearance with the request page action bar.
|
Superseded by #3674 |
2 similar comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3649
Hotfix to master
Current progress: