Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1682] Extract "just made a request" notice to partial #2078

Merged
merged 2 commits into from
Jan 13, 2015
Merged

[#1682] Extract "just made a request" notice to partial #2078

merged 2 commits into from
Jan 13, 2015

Conversation

garethrees
Copy link
Member

Fixes #1682

@garethrees garethrees mentioned this pull request Jan 7, 2015
Closed
4 tasks
@mysociety-pusher mysociety-pusher force-pushed the 1682-just-made-a-request branch from a0c26c3 to d8e5a1b Compare January 9, 2015 12:13
@garethrees
Copy link
Member Author

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0%) when pulling d8e5a1b on 1682-just-made-a-request into b9d5a77 on rails-3-develop.

@crowbot
Copy link
Member

crowbot commented Jan 9, 2015

I've added a comment to d8e5a1b, looks good apart from that.

@crowbot
Copy link
Member

crowbot commented Jan 12, 2015

👍

@garethrees
Use a partial to render request sent message
99fb6b4
@garethrees
Use a partial to render batch sent message
ebf549a 
Dropped the law_used_full interpolation:

    So I think there are two significant bits of context here. One is that the
    law_used_full attribute is derived from law_used, which in turn is set on
    InfoRequest initialisation based on the tags applied to the public body. So
    different requests in a batch could have different values for law_used_full
    - some of them might be to bodies that only accept environmental
    information requests. So using the value from the batch template is not
    really a good proxy for the whole collection.

    The second is that, in any case, the distinction between the two types of
    request is a UK-specific feature which should be moved to the UK theme
    (#2085).

    Given these two factors, I think the cleanest thing might be to drop
    law_used_full from this descriptive text, and just have it say "Your
    requests will be sent shortly", without specifying what law will be used.

    – Louise Crow (@crowbot)
@mysociety-pusher mysociety-pusher force-pushed the 1682-just-made-a-request branch from 2372441 to ebf549a Compare January 13, 2015 13:53
@mysociety-pusher mysociety-pusher merged commit ebf549a into rails-3-develop Jan 13, 2015
@mysociety-pusher mysociety-pusher deleted the 1682-just-made-a-request branch January 13, 2015 13:58
@henare henare mentioned this pull request Mar 12, 2015
Closed
@henare henare mentioned this pull request Mar 24, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garethrees @coveralls @crowbot @mysociety-pusher