Changes to final screen once a new request is complete

[wrightmartin]

Part of #1526

More sharing, better cross-selling

• Extract "You've just made a request" stuff to a partial ([#1682] Extract "just made a request" notice to partial #2078)
• Link up elements here ([#1682] Redesign final screen #2147 (comment))
• Implement sharing
• Replace $authority_name$ with actual authority name in sidebar

[crowbot]

See also mysociety/whatdotheyknow-theme#140

[garethrees]

Fixed in #2078

The new partial is at app/views/request/_request_sent.html.erb, so just replace its contents with the new stuff. You don't need to preserve div#notice – that's just to retain the existing styling.

[garethrees]

Oops PR closed this, but PR only covered the code bits

[wrightmartin]

Here's what it looks like implemented

[garethrees]

Definite improvement!

I think we have lost a bit of the boldness of the green flash message though. Could you add a screenshot with a bit more vertical (both up and down) context so we can see how it flows from the header and in to the request?

[wrightmartin]

@garethrees

[garethrees]

Yeah, I think it needs to be more obvious that its some sort of (large) alert and unique to the action the user has just taken. As a starting point, maybe render it within <div id="notice>" to reintroduce the (very) green notice box and add class=".subtle" to mute the colours?

[wrightmartin]

Yes, that looks better, thanks @garethrees

[garethrees]

Yeah that definitely stands out more! Do you think it feels okay at full size while going through the request process? I'm totally open to not putting it in a giant green box if you have other ideas.

Also I notice in the "What's Next" box there's "View other requests to $authority_name$ – assuming that's something you'd like us to do?

[garethrees]

Any coding bits, could you add to the to-do list at the top of the ticket? Cheers.

[garethrees]

Fixed in #2147