Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine the two hashes only if the file names differ #1302

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Dec 16, 2024

Closes #1301

Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/mwouts/jupytext.git@fix_contents_manager_hash

(this requires nodejs, see more at Developing Jupytext)

@mwouts mwouts force-pushed the fix_contents_manager_hash branch from 171f61d to b5c09b5 Compare December 16, 2024 23:18
@mwouts mwouts force-pushed the fix_contents_manager_hash branch from b5c09b5 to 54aeb24 Compare December 16, 2024 23:19
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.04%. Comparing base (1f5c68a) to head (54aeb24).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1302      +/-   ##
==========================================
+ Coverage   97.02%   97.04%   +0.02%     
==========================================
  Files          29       29              
  Lines        4501     4499       -2     
==========================================
- Hits         4367     4366       -1     
+ Misses        134      133       -1     
Flag Coverage Δ
external 75.07% <0.00%> (+0.03%) ⬆️
functional 88.39% <0.00%> (+0.04%) ⬆️
integration 77.28% <100.00%> (+0.01%) ⬆️
unit 66.48% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts merged commit 8409313 into main Dec 17, 2024
32 checks passed
@mwouts mwouts deleted the fix_contents_manager_hash branch December 17, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Warning: File Changed" when saving any notebook with 1.16.5
1 participant