Move tag handling to base website, update parser #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdicarlo
reviewed
Dec 12, 2023
mvdicarlo
reviewed
Dec 12, 2023
mvdicarlo
reviewed
Dec 12, 2023
mvdicarlo
reviewed
Dec 12, 2023
|
See comments and resolve merge conflicts. Solution is largely fine overall. |
aneillans
force-pushed
the
Change-Tags-Behaviour
branch
2 times, most recently
from
09fa2c6 to
8a5a499
Compare
aneillans
force-pushed
the
Change-Tags-Behaviour
branch
from
8a5a499 to
39f6aca
Compare
mvdicarlo
reviewed
Dec 19, 2023
mvdicarlo
reviewed
Dec 19, 2023
electron-app/src/server/websites/megalodon/megalodon.service.ts
Outdated
Show resolved
Hide resolved
mvdicarlo
reviewed
Dec 19, 2023
askmeaboutlo0m
added a commit
to askmeaboutlo0m/postybirb-plus
that referenced
this pull request
Jul 22, 2024
The validation functions would get passed the raw description as entered
by the user and would make some half-hearted effort to parse them into
something sensible, but this completely breaks down in the face of
shortcuts like {default}, username shortcuts that get turned into long
links etc. Now those functions get the actually parsed description
passed to them, the only unresolved shortcut in them being the `{tags}`
one, since the length of that is variable and up to the validation
function to deal with and tell the user if tags didn't fit.
Since mvdicarlo#286, tags insertion is also pretty much busted entirely, since it
runs at the wrong time, so it may insert too many tags and then cause an
error down the line because the resulting description is too long. That
insertion logic has now been moved to the end of the description
processing, where it belongs.
askmeaboutlo0m
added a commit
to askmeaboutlo0m/postybirb-plus
that referenced
this pull request
Jul 24, 2024
The validation functions would get passed the raw description as entered
by the user and would make some half-hearted effort to parse them into
something sensible, but this completely breaks down in the face of
shortcuts like {default}, username shortcuts that get turned into long
links etc. Now those functions get the actually parsed description
passed to them, the only unresolved shortcut in them being the `{tags}`
one, since the length of that is variable and up to the validation
function to deal with and tell the user if tags didn't fit.
Since mvdicarlo#286, tags insertion is also pretty much busted entirely, since it
runs at the wrong time, so it may insert too many tags and then cause an
error down the line because the resulting description is too long. That
insertion logic has now been moved to the end of the description
processing, where it belongs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #280 this focusses on correcting only the parsers behaviour (took a cleaner route this time).
Went through the integrations and checked them as much as I could, removed injection where found, removed unnecessary code, but also trying to use base class functionality for as much as possible.