Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag shortcut expansion #280

Closed
wants to merge 5 commits into from

Conversation

aneillans
Copy link
Contributor

This resolves a couple of issues around using the {tags} shortcut in descriptions for services such as Mastodon, Pleroma, Bluesky etc

The {tags} shortcut was not going through the convertors, so was not parsing properly, it also was not parsing out spaces correctly (i.e. website specific adaptions).

Also added an option to the sites that we are currently appending the tags automatically onto descriptions on to allow turning this off for people that might be using the {tags} shortcut to avoid duplication.

@mvdicarlo
Copy link
Owner

So overall I am not really fine about this change and am likely to reject it.
My typical philosophy is that if a user wanted tags in their description they should add it in manually. Annoying? Yes. But supporting auto-injection is unwieldy and likely to have unintended affects for a user's post.

I was already hesitant about tag injection within mastodon and the such and this is kind of re-affirming my bias.
I am more tempted to just remove the hashtag injection as it exists now, add the parsing section into the description parser for {tags} and call it there.

@aneillans
Copy link
Contributor Author

Don't see an issue with that approach; removing the auto injection of tags wouldn't be an issue if {tags} parsing was corrected (as per this PR or another implementation).

@mvdicarlo
Copy link
Owner

Will look into that if you don't after I figure out the furrynetwork nightmare.

Overall the change will be to remove tag injection that happens in any posting logic (mastodon, etc.). Ensure that all implementations aren't doing any weird tag modification outside of their parseTags functions, and then making the description parser able to correctly inject.

@aneillans
Copy link
Contributor Author

Yeah - I should get time to take a look this week - will let you know :)

@aneillans
Copy link
Contributor Author

Closing this, as superseded by 286.

@aneillans aneillans closed this Dec 9, 2023
@aneillans aneillans deleted the Tag-Shortcut-Expansion branch January 5, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants