-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Handle touch cancel event just like touch end. #9
Conversation
In scenarios where touch end does not get fired but touch cancel does, SwiftClick leads to users having to click twice to actually click on an element. So, handling touchcancel event just like touch end event is necessary.
@prashantpalikhe nice, thanks. I don't have time to test right now... does this fix #8? |
No, this does not fix #8. I'll create a PR for that one by getting rid of the ghost click related code. No worries. |
Looking at this, a click event will be generated within the |
Updated the PR, can you have a look? |
Thanks for updating it, I'll take a look this evening. |
@prashantpalikhe the PR looks good, but can you change the function name to I'll merge once that's done 👍 |
Done! |
Can you create a new tag for the repo? |
Tagged and published to npm 😄 |
In scenarios where
touchend
does not get fired buttouchcancel
does, SwiftClick leads to users having to click twice to actually click on an element. So, handlingtouchcancel
event just liketouchend
event is necessary.