-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form with a submit button requires double click for submission when SwiftClick is enabled. #8
Comments
@prashantpalikhe thanks for the detailed report. Perhaps buttons with a type of I will, however, consider removing the ghost click prevention code, as this was aimed at quite an old Android version, if I remember correctly. |
@munkychop Swiftclick ignoring won't be enough though. Because the OS fires the click event and the handler executes nevertheless. Would be awesome if the ghost click prevention is no longer necessary. |
@prashantpalikhe this is going to have to wait for a week or so, as I'm crazy busy right now. I will take a look when I get a minute, though. |
@prashantpalikhe while refactoring the whole project into ES2015 I looked into solving this issue, along with #10, while retaining the ghost click prevention. Would you be able to pull and switch to the To start the project within that branch you'll need to run |
@prashantpalikhe were you ever able to test this? |
Nope, have not been able to. |
Ok, I'll try and get some testing done on the weekend, if I can find the time. |
The issue is replicated on the following bin
http://jsbin.com/vuwukeqapi/
You can load this bin on iOS safari to see the issue.
Basically what's happening is:
_clickedAlready
variable is set to true from any previous clicks, the click handler cancels the event. Therefore, cancelling the form submission on the first click.The text was updated successfully, but these errors were encountered: