Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update #290 with remaining signatures #291

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Update #290 with remaining signatures #291

merged 3 commits into from
Sep 16, 2022

Conversation

expede
Copy link
Contributor

@expede expede commented Sep 15, 2022 •
edited
Loading

@expede expede marked this pull request as ready for review September 15, 2022 05:48
@expede
Copy link
Contributor Author

expede commented Sep 15, 2022

@Gozala I guess that I don't have push rights onto branches on multiformats/multicodec. Here's a branch into your PR from my fork.

expede
expede commented Sep 15, 2022
View reviewed changes
table.csv
es256, varsig, 0xd01200, draft, ES256 Signature Algorithm
es284, varsig, 0xd01201, draft, ES384 Signature Algorithm
es512, varsig, 0xd01202, draft, ES512 Signature Algorithm
rs256, varsig, 0xd01205, draft, RS256 Signature Algorithm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that's annoying! validate.py takes the entire sequence as a number, so fails if we keep the signatures together 🤷‍♀️

@expede expede mentioned this pull request Sep 15, 2022
Merged
@expede expede changed the title Update with remianing signatures from ucan-ipld Update with remaining signatures on #290 Sep 15, 2022
@expede expede changed the title Update with remaining signatures on #290 Update #290 with remaining signatures Sep 15, 2022
@Gozala Gozala merged commit ddaabfa into multiformats:feat/varsig Sep 16, 2022
@expede expede deleted the feat/varsig branch September 16, 2022 18:41
rvagg added a commit that referenced this pull request Oct 16, 2024
@rvagg
fix: rename bls-12381* to bls12_381* for consistency
d885c7b 
The poseidon bls12 entries already exist to mark this convention and we have a note in the README that calls this example out specifically.

Ref: #291
Ref: #361
Ref: #356
@rvagg rvagg mentioned this pull request Oct 16, 2024
Merged
rvagg added a commit that referenced this pull request Oct 24, 2024
@rvagg
fix: rename bls-12381* to bls12_381* for consistency (#362)
352d05a 
The poseidon bls12 entries already exist to mark this convention and we have a note in the README that calls this example out specifically.

Ref: #291
Ref: #361
Ref: #356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@expede @Gozala