fix: rename bls-12381* to bls12_381* for consistency #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
commented
Oct 16, 2024
|
Whoops! Sure, that works — thanks :) |
|
@vmx can you 👍 please? looks like we can't override that but maybe we should, or expand the list |
vmx
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The poseidon bls12 entries already exist to mark this convention and we have a note in the README that calls this example out specifically.
Ref: #291
Ref: #361
Ref: #356
I only noticed this discrepancy when looking at #361.
@expede is this gong to hurt anyone that you know of if we change this