add webrtc #131
add webrtc #131
Conversation
There was a problem hiding this comment.
This looks good to me. Thanks @ckousik.
As far as I can tell webrtc and certhash is still missing in https://github.com/multiformats/multicodec/blob/master/table.csv. (Each multiaddr component is also a multicodec.) Would you mind filing a pull request there as well?
Once that is in, we can merge here.
| @@ -33,5 +33,6 @@ code, size, name, comment | |||
| 277, 0, p2p-stardust, | |||
| 275, 0, p2p-webrtc-star, | |||
| 276, 0, p2p-webrtc-direct, | |||
| 280, 0, webrtc, ICE-lite webrtc transport | |||
There was a problem hiding this comment.
If I understand correctly "ICE-lite" can only be used as a WebRTC server. In other words a browser can not do "ICE-lite", i.e. uses different UDP ports for each connection and does not know its port upfront and thus goes through the whole ICE process. Please correct me if I am wrong.
While I think the "ICE-lite webrtc transport" description is fine for now, I would hope for browsers to be able to re-use the same protocol component (/webrtc) in the browser-to-browser use-case, thus we might change the description later on.
There was a problem hiding this comment.
A lite implementation is only appropriate for devices that will always be connected to
the public Internet and have a public IP address at which it can receive packets from any
correspondent. ICE will not function when a lite implementation is placed behind a NAT
(RFC8445).
There was a problem hiding this comment.
Just following up here, the initial hope, namely to reuse /webrtc for browser-to-browser (now called webrtc-w3c) is not possible. See libp2p/specs#497 which uses /webrtc-w3c instead.
|
//CC @melekes (no actions required) |
There was a problem hiding this comment.
opened multiformats/multicodec#279 and multiformats/multicodec#280
With these merged, let's proceed here. Thanks @ckousik and @melekes.
Update for multiformats/multiaddr#130 and multiformats/multiaddr#131 Even though I disagree with these protocols, I guess the way forward is to conform.
Add protocol code point for webrtc.
multiformats/go-multiaddr#179
libp2p/specs#412