-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Check link validity in PR #6497
Conversation
These are the results for the performance tests:
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
2287df6
to
474a37c
Compare
Does the logic find this 404 link on HEAD?
(there is the same 404 on a couple of other pages) |
Yes 🎉 Report after going on
A detailed report (I removed the false positive)
|
It's weird. The import was fine with From what I understand, the file Doing the following modification in the -const { createRender } = require('@mui/markdown');
+const { createRender } = require('../packages/markdown'); So a solution could be to this modification in the material-ui repository. Maybe there is another solution, but it's out of my knowledge about package alias |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@alexfauquette I have pushed a fix for it, the tricky aspect is that there is a lot happening beyond the scene that is hard to pinpoint the origin of where it starts and where it ends. I hope mui/material-ui#34841 (comment) and my commit bring a bit more clarity on how this fits together. I moved the script execution location to use the babel config of the root that is optimized to run scripts from the mono repo, while the babel config of the docs is designed to build the docs pages. The CI is still not green but I think a rebase on HEAD would solve the problem, taking #6549 in. |
Reuse helper proposed in mui/material-ui#34588
Remaining: wait for core release, to update monorepo