-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Basic link verification at PR level #34588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
force-pushed
the
fix-links
branch
from
October 10, 2022 09:58
6307a6a
to
e1a72e2
Compare
alexfauquette
force-pushed
the
fix-links
branch
from
October 10, 2022 10:26
e1a72e2
to
f22b80c
Compare
alexfauquette
changed the title
[docs] fix links
[docs] Basic link verification at PR level
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It seems that we found the issues before ahrefs :) https://app.ahrefs.com/site-audit/3524616/33/overview
alexfauquette
added
the
website
Pages that are not documentation-related, marketing-focused.
label
Oct 14, 2022
oliviertassinari
approved these changes
Oct 14, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add automatic verification for internal links inside this repository.
During static tests, it runs
yarn docs:link-check
which will generate a report about unfound links in the filedocs/broken-links.txt
If the file get changed by the PR, the test will fail. Then you have two solutions:
yarn docs:link-check
and add the updatedbroken-links.txt
to your PRI created a dedicated draft PR to show how the test fails when you modify the title of a section but not link anchors referring to it
PR (and the failing test)
That could help @samuelsycamore when renaming sections