Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Playwright 1.49 #15493

Open
wants to merge 35 commits into
base: master
Choose a base branch
from
Open

[code-infra] Playwright 1.49 #15493

wants to merge 35 commits into from

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Nov 19, 2024 •
edited by LukasTy
Loading

Closes #13672.
Closes #14948.

@JCQuintas JCQuintas added scope: code-infra Specific to the core-infra product test labels Nov 19, 2024
@JCQuintas JCQuintas self-assigned this Nov 19, 2024
@mui-bot
Copy link

mui-bot commented Nov 19, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15493--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against f1a9549

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 20, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@LukasTy LukasTy mentioned this pull request Nov 22, 2024
Open
1 task
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 25, 2024
@JCQuintas JCQuintas marked this pull request as ready for review November 26, 2024 15:21
@JCQuintas
Copy link
Member Author

@LukasTy I've divided the e2e tests... they are interfering with eachother a lot due to async bleeding everywhere.

The DataGrid runs independently while the other tests are bundled together.
When DataGrid runs with the other tests, a lot of timeouts and async errors happen with DatePickers and TreeView.

This is probably similar reason why the tests are failing on vitest as well. IMO we should look into adding eslint rules to force everyone to use the correct test patterns, though it is a bit difficult cause I think some of the issues come from core's test utils as well 😢

@JCQuintas JCQuintas mentioned this pull request Nov 27, 2024
Open
1 task
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 28, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy Awaiting requested review from LukasTy

At least 1 approving review is required to merge this pull request.

Assignees

@JCQuintas JCQuintas

Labels
scope: code-infra Specific to the core-infra product test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JCQuintas @mui-bot