Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Playwright to 1.49.0 #44527

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Bump Playwright to 1.49.0 #44527

wants to merge 9 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 24, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@playwright/test (source) 1.48.2 -> 1.49.0 age adoption passing confidence
playwright (source) ^1.48.2 -> ^1.49.0 age adoption passing confidence
playwright (source) 1.48.2 -> 1.49.0 age adoption passing confidence

Release Notes

microsoft/playwright (@​playwright/test)

v1.49.0

Compare Source


Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Update of dependencies label Nov 24, 2024
@mui-bot
Copy link

mui-bot commented Nov 24, 2024

Netlify deploy preview

https://deploy-preview-44527--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 92bdddd

Copy link
Contributor Author

renovate bot commented Nov 25, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 25, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Nov 25, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 25, 2024
@aarongarciah aarongarciah requested a review from a team November 25, 2024 13:07
@aarongarciah
Copy link
Member

@mui/code-infra Renovate didn't update the Docker image version in .circleci/config.yml as it did in previous Playwright bumps https://github.com/mui/material-ui/pull/44222/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R383

@JCQuintas
Copy link
Member

@mui/code-infra Renovate didn't update the Docker image version in .circleci/config.yml as it did in previous Playwright bumps https://github.com/mui/material-ui/pull/44222/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R383

It can't update images because new versions don't use ubuntu focal anymore. Gotta move them to noble

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 25, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 25, 2024
@aarongarciah
Copy link
Member

After manually pointing Playwright Docker images to playwright:v1.49.0-noble, the test_regression check fails: ReferenceError: __dirname is not defined

https://app.circleci.com/pipelines/github/mui/material-ui/143497/workflows/ca1efb19-79a9-4523-9b6a-9010a8de2c37/jobs/772782

@michaldudak
Copy link
Member

We had the same issue in Base UI. For some reason, the main test file has to be proper CommonJS or ESM, not a blend of both (which is actually a good thing).

See https://github.com/mui/base-ui/pull/836/files#diff-a00cb0d81882c4a00f2935b720a1e611c08e123551be2103da06c7022cd35ae7

@aarongarciah
Copy link
Member

aarongarciah commented Nov 27, 2024

Thanks @michaldudak. It now works after applying that change.

@mui/code-infra this is ready for review. There's a lot of changed screenshots in Argos (946), most of them probably caused by the Chromium version update (129 -> 131) causing minor differences in text rendering.

@JCQuintas
Copy link
Member

We had the same issue in Base UI. For some reason, the main test file has to be proper CommonJS or ESM, not a blend of both (which is actually a good thing).

See https://github.com/mui/base-ui/pull/836/files#diff-a00cb0d81882c4a00f2935b720a1e611c08e123551be2103da06c7022cd35ae7

This is odd, we didn't have this issue. mui/mui-x#15493

@JCQuintas
Copy link
Member

Thanks @michaldudak. It now works after applying that change.

@mui/code-infra this is ready for review. There's a lot of changed screenshots in Argos (946), most of them probably caused by the Chromium version update (129 -> 131) causing minor differences in text rendering.

Our argos changed a lot as well

Comment on lines +1 to +3
const path = require('path');
const fse = require('fs-extra');
const playwright = require('playwright');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the issue is that you are using @mui/internal-test-utils/setupBabelPlaywright inside test/regressions/.mocharc.js instead of @mui/internal-test-utils/setupBabel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The playwright specific config seems unnecessary to me btw, maybe we should remove it @michaldudak

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this to setupBabel causes the tests in Base UI to explode, so it may require a bit more work. I'd love to get rid of webpack and mocha and replace them with vite and vitest at some point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, but this seems to work in core. I'm still having trouble with vitest on X, but the next step would be to try to use the same tools everywhere indeed.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants