-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Playwright to 1.49.0 #44527
base: master
Are you sure you want to change the base?
Bump Playwright to 1.49.0 #44527
Conversation
Netlify deploy previewhttps://deploy-preview-44527--material-ui.netlify.app/ Bundle size report |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
cf21bbf
to
126c08c
Compare
126c08c
to
5c987c5
Compare
5c987c5
to
dc94959
Compare
@mui/code-infra Renovate didn't update the Docker image version in |
It can't update images because new versions don't use ubuntu focal anymore. Gotta move them to |
9eebeb6
to
365c0af
Compare
After manually pointing Playwright Docker images to |
We had the same issue in Base UI. For some reason, the main test file has to be proper CommonJS or ESM, not a blend of both (which is actually a good thing). |
Thanks @michaldudak. It now works after applying that change. @mui/code-infra this is ready for review. There's a lot of changed screenshots in Argos (946), most of them probably caused by the Chromium version update (129 -> 131) causing minor differences in text rendering. |
This is odd, we didn't have this issue. mui/mui-x#15493 |
Our argos changed a lot as well |
const path = require('path'); | ||
const fse = require('fs-extra'); | ||
const playwright = require('playwright'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the issue is that you are using @mui/internal-test-utils/setupBabelPlaywright
inside test/regressions/.mocharc.js
instead of @mui/internal-test-utils/setupBabel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The playwright specific config seems unnecessary to me btw, maybe we should remove it @michaldudak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this to setupBabel
causes the tests in Base UI to explode, so it may require a bit more work. I'd love to get rid of webpack and mocha and replace them with vite and vitest at some point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, but this seems to work in core. I'm still having trouble with vitest on X, but the next step would be to try to use the same tools everywhere indeed.
This PR contains the following updates:
1.48.2
->1.49.0
^1.48.2
->^1.49.0
1.48.2
->1.49.0
Release Notes
microsoft/playwright (@playwright/test)
v1.49.0
Compare Source
Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.