Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fields] Enable the new field DOM structure by default #14651

Merged

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Sep 17, 2024

Closes #14477

If possible, this PR should be merged as soon as the next branch is prepared so that I can open the PR to #14796 which also impacts most of the interfaces in the package.

Work

  • Enable enableAccessibleFieldDOMStructure when the prop is not provided and render the right text field
  • Change the default value of the TEnableAccessibleFieldDOMStructure generic in every component and interface using it
  • Stop usign enableAccessibleFieldDOMStructure={true} in doc and tests
  • Create the migration guide for v8 and move the guide to migrate to the new DOM structure there
  • Update the "Custom field" page to use the new DOM structure by default an only advertise the legacy one for Joy UI
  • Use the terminology "Accessible DOM structure" / "Non-accessible DOM structure" everywhere instead of "v6" / "v7" or "legacy"

@flaviendelangle flaviendelangle self-assigned this Sep 17, 2024
@flaviendelangle flaviendelangle added breaking change component: pickers This is the name of the generic UI component, not the React module! v8.x labels Sep 17, 2024
Copy link
Member

@arthurbalduini arthurbalduini left a comment

@arthurbalduini
Copy link
Member

Maybe we already want to remove the "v6" x "v7" terminology for good ?

Although I think it can make sense, I also see it as questionable since adding new suffixes could make it more verbose and hardly to read, plus we are already used to the v6 x v7 nomenclature. I wouldn't mind leaving the renaming for v9 once we remove the non-accessible-v6 input

Copy link
Member

@arthurbalduini arthurbalduini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏
Nice to see so many removed lines, specially in our tests ! 🎉

I'm leaving the approve, I believe the v7xv6 nomenclature doesn't block this PR 🙂

@flaviendelangle
Copy link
Member Author

flaviendelangle commented Oct 16, 2024

Thanks for the deep dive on the v6/v7 nomenclature.

Although I think it can make sense, I also see it as questionable since adding new suffixes could make it more verbose and hardly to read, plus we are already used to the v6 x v7 nomenclature. I wouldn't mind leaving the renaming for v9 once we remove the non-accessible-v6 input

I would differenciate public usage of the nomenclature and internal one.
The public usage is "accessible DOM structure", not "v7 DOM structure", so I think any public usage should still follow this nomenclature as muche as possible.
From what I can see, the only public interfaces remaining with v6/v7 is BaseForwardedV6SingleInputFieldProps/BaseForwardedV7SingleInputFieldProps which I can rename but is very rarely used (and is even less useful with the multi input field going away).

All the rest is purely internal, I can rename it for consistency, but as you said everything will go away in v9 so it may not be worth the effort.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 17, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 18, 2024
@flaviendelangle flaviendelangle merged commit 509b12d into mui:master Oct 22, 2024
16 checks passed
@flaviendelangle flaviendelangle deleted the enabledAccessibleFieldDOMStructure branch October 22, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! v8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pickers] Make the <input /> version of the fields opt-in
3 participants