[pickers] Remove `TDate` generics in favor of `PickerValidDate` direct usage #15001

flaviendelangle · 2024-10-16T17:13:57Z

Side note: all PickerValidDate | null passed as a generic will be replaced with a true or false once TValue is replaced by TIsRange (phrase 2 of #14823).

I will do the migration guide after the phase 2 of #14823 to have a finalized list of the breaking changes on the generics.

github-actions · 2024-10-29T13:01:00Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

LukasTy

This is a massive improvement on the codebase. 💙 😍
Thank you for working on it! 🙏
However, I'm really not fond of the ugly solutions we have to take for docs. 🙈

Have you tried exploring a solution of localized PickerValidDate redefining? 🤔

.circleci/config.yml

LukasTy · 2024-10-28T16:00:11Z

docs/data/date-pickers/base-concepts/ReferenceDateExplicitDateTimePicker.tsx

@@ -18,7 +19,7 @@ export default function ReferenceDateExplicitDateTimePicker() {
          referenceDate={dayjs('2022-04-17T15:30')}
        />
        <Typography>
-          Stored value: {value == null ? 'null' : value.format()}
+          Stored value: {value == null ? 'null' : (value as Dayjs).format()}


Oh yes, this isn't lovely. 🙈
I think that if we are going forward with this approach, we need a way to avoid the need for casting. 🙈
At least in the generated "preview".
Maybe we could by default enforce 'Dayjs' type and keep the option to override the type in those few instances where another adapter is used? 🤔

docs/data/date-pickers/custom-field/BrowserV7SingleInputRangeField.tsx

docs/data/date-pickers/custom-field/custom-field.md

docs/data/date-pickers/validation/DateValidationShouldDisableDate.tsx

packages/x-date-pickers-pro/src/StaticDateRangePicker/StaticDateRangePicker.test.tsx

packages/x-date-pickers/src/locales/beBY.ts

LukasTy · 2024-10-29T13:23:11Z

packages/x-date-pickers/src/models/value.ts

@@ -0,0 +1,6 @@
+import { PickerValidDate } from './pickers';
+
+export type SimpleValue = PickerValidDate | null;


SimpleValue sounds somewhat strange. 🤷
Have you considered PickerValue?

Suggested change

export type SimpleValue = PickerValidDate | null;

export type PickerValue = PickerValidDate | null;

I would like to rename DateRange in a follow up to have both interfaces being named coherently.
I was going for SimpleValue / RangeValue, but we could go for PickerValue / PickerRangeValue if you prefer.

My vote goes for the PickerValue and PickerRangeValue. 👍
WDYT @arthurbalduini?

LukasTy · 2024-10-29T13:26:16Z

test/utils/pickers/describeRangeValidation/testTextFieldKeyboardRangeValidation.tsx

@@ -113,23 +113,23 @@ export const testTextFieldKeyboardRangeValidation: DescribeRangeValidationTestSu
      }

      act(() => {
-        setValue(adapterToUse.date(past));
+        setValue(past);


👏 🙈 😆

flaviendelangle · 2024-10-29T13:42:44Z

Have you tried exploring a solution of localized PickerValidDate redefining? 🤔

How would you do that?

github-actions · 2024-10-29T13:43:36Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>

github-actions · 2024-10-29T14:01:32Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

flaviendelangle · 2024-10-31T07:47:17Z

@LukasTy one option would be to add the following code in one of the doc files:

declare module '@mui/x-date-pickers/models' {
  interface PickerValidDateLookup {
    fakeDocAdapter: any;
  }
}

It would not impact Codesandbox / Stackblitz.
We would have any as a value in the doc examples but I don't think we care since today we have the union of all the date library types and we never really missed this type safety.

github-actions · 2024-10-31T10:52:20Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-10-31T14:35:33Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

flaviendelangle added 30 commits September 17, 2024 13:28

[fields] Enable the new field DOM structure by default

dcfddcc

Regen API

28cd5ea

Fix links

7b1784d

Remove enableAccessibleFieldDOMStructure prop when not needed

931a1a1

Fix

25a258d

Fix

fab5833

Merge branch 'master' into enabledAccessibleFieldDOMStructure

65e3462

Merge

edfddd3

Merge branch 'master' into enabledAccessibleFieldDOMStructure

9c1c822

Merge branch 'master' into enabledAccessibleFieldDOMStructure

28dbc40

Fix

5a8a5ec

Merge branch 'master' into enabledAccessibleFieldDOMStructure

e634bab

Merge branch 'master' into enabledAccessibleFieldDOMStructure

a029653

Work

448f209

Work

af1436e

Work

eed2459

Work

2b5dfeb

Work

2faf846

Work

832baaf

Work

f6963d7

Work

3d6bc8d

Merge branch 'master' into enabledAccessibleFieldDOMStructure

dec8394

Merge branch 'master' into enabledAccessibleFieldDOMStructure

626ed02

Merge branch 'master' into enabledAccessibleFieldDOMStructure

8b7a8f6

Fix

80eac3b

Merge branch 'master' into enabledAccessibleFieldDOMStructure

1f3d73c

Merge branch 'master' into enabledAccessibleFieldDOMStructure

7bedcd5

Review: Arthur

5f76be6

Merge branch 'master' into enabledAccessibleFieldDOMStructure

24334a1

[pickers] Remove TDate generics in favor of PickerValidDate direct usage

f003b41

Merge

f866561

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 29, 2024

flaviendelangle added 3 commits October 29, 2024 14:09

Work

98eb539

Fix

a1e1090

Fix CI

a2435b0

LukasTy reviewed Oct 29, 2024

View reviewed changes

Review: Lukas

df2da8c

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 29, 2024

Fix

f8e43e7

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 29, 2024

Update .circleci/config.yml

3851a35

Co-authored-by: Lukas Tyla <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>

flaviendelangle requested a review from LukasTy October 29, 2024 13:56

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 29, 2024

Fix

47f3e6d

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 29, 2024

Fix

b252ca8

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2024

Merge

98a52a9

github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Oct 31, 2024

Merge

d6a3284

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2024

Review: Lukas

dee0238

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pickers] Remove `TDate` generics in favor of `PickerValidDate` direct usage #15001

[pickers] Remove `TDate` generics in favor of `PickerValidDate` direct usage #15001

flaviendelangle commented Oct 16, 2024 •

edited

Loading

github-actions bot commented Oct 29, 2024

LukasTy left a comment

LukasTy Oct 28, 2024

LukasTy Oct 29, 2024

flaviendelangle Oct 29, 2024 •

edited

Loading

LukasTy Oct 29, 2024

LukasTy Oct 29, 2024

flaviendelangle commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

flaviendelangle commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

		@@ -0,0 +1,6 @@
		import { PickerValidDate } from './pickers';

		export type SimpleValue = PickerValidDate \| null;

	export type SimpleValue = PickerValidDate \| null;
	export type PickerValue = PickerValidDate \| null;

[pickers] Remove TDate generics in favor of PickerValidDate direct usage #15001

Are you sure you want to change the base?

[pickers] Remove TDate generics in favor of PickerValidDate direct usage #15001

Conversation

flaviendelangle commented Oct 16, 2024 • edited Loading

github-actions bot commented Oct 29, 2024

LukasTy left a comment

Choose a reason for hiding this comment

LukasTy Oct 28, 2024

Choose a reason for hiding this comment

LukasTy Oct 29, 2024

Choose a reason for hiding this comment

flaviendelangle Oct 29, 2024 • edited Loading

Choose a reason for hiding this comment

LukasTy Oct 29, 2024

Choose a reason for hiding this comment

LukasTy Oct 29, 2024

Choose a reason for hiding this comment

flaviendelangle commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

github-actions bot commented Oct 29, 2024

flaviendelangle commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Oct 31, 2024

[pickers] Remove `TDate` generics in favor of `PickerValidDate` direct usage #15001

[pickers] Remove `TDate` generics in favor of `PickerValidDate` direct usage #15001

flaviendelangle commented Oct 16, 2024 •

edited

Loading

flaviendelangle Oct 29, 2024 •

edited

Loading