Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Update package layout for better ESM support #14386

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

[code-infra] Update package layout for better ESM support #14386

wants to merge 20 commits into from
+75 −45

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 29, 2024 •
edited
Loading

Bringing mui/material-ui#43264 to X so I can start integration testing core and X together

Updates to the package layout:

  • flatter layout with
    • ./index.js => cjs
    • ./index.mjs => esm
    • ./index.modern.mjs => modern
    • ./index.d.ts => types
  • package.json exports to route bundlers and runtimes to the correct module
  • depends on [code-infra] Fully resolve imports in ESM target #14234 for full ESM support. This will make the packages importable in native Node.js ESM if you so wish.
  • behind a MUI_USE_PACKAGE_EXPORTS flag for now to mimic core.

to do

  • manual integration testing
  • Remove the MUI_USE_PACKAGE_EXPORTS flag

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Aug 29, 2024
@mui-bot
Copy link

mui-bot commented Aug 29, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14386--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 77c8e88

@Janpot Janpot mentioned this pull request Aug 30, 2024
Closed
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 30, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 30, 2024
@Janpot Janpot mentioned this pull request Aug 30, 2024
Draft
1 task
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 4, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @mui-bot