-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Fully resolve imports in ESM target #14234
Conversation
Deploy preview: https://deploy-preview-14234--material-ui-x.netlify.app/ |
Tried out with the dataGrid through the csbci published packages and no issues found |
@alexfauquette added you here cause you might have feedback based on #13608 |
For reference, the next steps are
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@JCQuintas @alexfauquette This PR doesn't touch the build process of |
Just to be sure, "this PR does not touch the build process of
// `x-charts-vendor/d3-color` (ESM)
// See upstream license: https://github.com/d3/d3-color/blob/main/LICENSE
//
// Our ESM package uses the underlying installed dependencies of `node_modules/d3-color`
export * from "d3-color"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried two codesandboxes, and looked at some of the diff in the build folders. The modification looks ok.
|
Stepping stone towards full ESM support.
This babel plugin replaces imports with their full resolved path + extension.
./path/to/module
becomes./path/to/module.js
or./path/to/module/index.js
, depending on where it resolves to.See mui/material-ui#43294
blocked on