Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pigment-css][nextjs-plugin] Follow-up to #41494 #41502

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

brijeshb42
Copy link
Contributor

Resolve React and other related libraries to the actual ones in node_modules instead of Next.js' own version of React that will also include RSC related code that is not actually needed during WyW eval.

It also fixes the next.js demo app which broke after merging #41494

@brijeshb42 brijeshb42 added nextjs package: pigment-css Specific to @pigment-css/* labels Mar 15, 2024
@mui-bot
Copy link

mui-bot commented Mar 15, 2024

Netlify deploy preview

https://deploy-preview-41502--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 17dd2c1

@brijeshb42 brijeshb42 changed the title [pigment-css][nextjs-plugin] Follow to #41494 [pigment-css][nextjs-plugin] Follow-up to #41494 Mar 15, 2024
@brijeshb42 brijeshb42 force-pushed the pigment/next-resolve-followup branch from c3f6d9a to fd3298f Compare March 15, 2024 08:01
Resolve React and other related libraries to the actual ones in
node_modules instead of Next.js' own version of React that will also
include RSC related code that is not actually needed during WyW eval.
@brijeshb42 brijeshb42 force-pushed the pigment/next-resolve-followup branch from fd3298f to b0f46fd Compare March 15, 2024 08:02
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Co-authored-by: Siriwat K <[email protected]>
Signed-off-by: Brijesh Bittu <[email protected]>
@brijeshb42 brijeshb42 enabled auto-merge (squash) March 15, 2024 09:42
@brijeshb42 brijeshb42 merged commit 257b5a4 into mui:master Mar 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nextjs package: pigment-css Specific to @pigment-css/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants