[pigment-css][nextjs-plugin] Fix alias resolver #41494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41494--material-ui.netlify.app/ Bundle size report |
brijeshb42
force-pushed
the
pigment/next-resolve
branch
2 times, most recently
from
114daab
to
1750e44
Compare
Uses webpack's internal resolver to resolve aliased paths during WyW's evaluation phase.
brijeshb42
force-pushed
the
pigment/next-resolve
branch
from
1750e44
to
8a8e9ce
Compare
siriwatknp
reviewed
Mar 15, 2024
| return result; | ||
| } | ||
| // Use Webpack's resolver to resolve actual path but | ||
| // ignore next.js files during evaluation phase of WyW |
There was a problem hiding this comment.
Not related to this PR but it seems like we can ignore the emotion as well for the .toString error, right?
There was a problem hiding this comment.
Let me check if it fixes emotion related issue but I am sure these two are unrelated. Maybe we can point that emotion import to a dummy file similar to what we do for next/image/next/font.
brijeshb42
added a commit
to brijeshb42/material-ui
that referenced
this pull request
Mar 15, 2024
Resolve React and other related libraries to the actual ones in node_modules instead of Next.js' own version of React that will also include RSC related code that is not actually needed during WyW eval.
1 task
brijeshb42
added a commit
to brijeshb42/material-ui
that referenced
this pull request
Mar 15, 2024
Resolve React and other related libraries to the actual ones in node_modules instead of Next.js' own version of React that will also include RSC related code that is not actually needed during WyW eval.
brijeshb42
added a commit
to brijeshb42/material-ui
that referenced
this pull request
Mar 15, 2024
Resolve React and other related libraries to the actual ones in node_modules instead of Next.js' own version of React that will also include RSC related code that is not actually needed during WyW eval.
brijeshb42
added a commit
that referenced
this pull request
Mar 15, 2024
Signed-off-by: Brijesh Bittu <[email protected]> Co-authored-by: Siriwat K <[email protected]>
This was referenced May 19, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 5, 2024
This was referenced Jun 6, 2024
This was referenced Jun 6, 2024
This was referenced Jun 15, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses webpack's internal resolver to resolve aliased paths during WyW's evaluation phase.
This allows WyW to resolve aliased paths (through tsconfig) in Next.js to their actual paths.
Closes #41482