Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Lock @types/node to v18 #37965

Merged
merged 4 commits into from
Jul 14, 2023

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Jul 14, 2023

Similar to mui/mui-x#9107.

Closes #37880.

Despite the statement in #37793 (comment), Renovate still opened a pull request (#37880) for the update. See the discussion in #37793.

@ZeeshanTamboli ZeeshanTamboli added core Infrastructure work going on behind the scenes dependencies Update of dependencies labels Jul 14, 2023
@mui-bot
Copy link

mui-bot commented Jul 14, 2023

Netlify deploy preview

https://deploy-preview-37965--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against cd13204

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review July 14, 2023 13:02
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it seems that we can't always trust what's written. 🙈

package.json Outdated Show resolved Hide resolved
@ZeeshanTamboli ZeeshanTamboli merged commit 5dbf034 into mui:master Jul 14, 2023
@ZeeshanTamboli ZeeshanTamboli deleted the lock-node-version-to-v18 branch July 14, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants