Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @types/node to ^20.3.3 #37793

Closed
wants to merge 1 commit into from
Closed

Bump @types/node to ^20.3.3 #37793

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 2, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/node (source) ^18.16.18 -> ^20.3.3 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Update of dependencies label Jul 2, 2023
@mui-bot
Copy link

mui-bot commented Jul 2, 2023

Netlify deploy preview

https://deploy-preview-37793--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 803387e

@ZeeshanTamboli ZeeshanTamboli deleted the renovate/node-20.x branch July 3, 2023 08:38
@renovate
Copy link
Contributor Author

renovate bot commented Jul 3, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 20.x releases. But if you manually upgrade to 20.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@LukasTy
Copy link
Member

LukasTy commented Jul 6, 2023

@mui/core You can consider locking node to v18 as we did on the X side to avoid these bumps, until that's our selected target.
mui/mui-x#9107

@ZeeshanTamboli
Copy link
Member

@mui/core You can consider locking node to v18 as we did on the X side to avoid these bumps, until that's our selected target. mui/mui-x#9107

I will take a look. 👍

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Jul 7, 2023

@LukasTy I think renovate will ignore this update until we manually update to 20.x (major version) as per #37793 (comment).

@LukasTy
Copy link
Member

LukasTy commented Jul 7, 2023

Hmmm, nice. If it will actually work as described, then it's even better, less work on our end. 👌 👍
The question is, will it still create renovate PRs for the v18? 🤔

@ZeeshanTamboli
Copy link
Member

will it still create renovate PRs for the v18?

I believe it will because it specifically mentions 20.x and says we will not get any future updates for 20.x releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants