Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Add bundle fixtures #23166

Merged
merged 60 commits into from
Jun 1, 2021
Merged

[test] Add bundle fixtures #23166

merged 60 commits into from
Jun 1, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 19, 2020

Act as a smoke test for the bundle layout.

Example run: https://app.circleci.com/pipelines/github/mui-org/material-ui/42820/workflows/210cfd58-b66f-4c3e-a3a5-4e9c00681603

TODO:

  • node {12,14,16} with ES modules
  • create-react-app
  • nextjs + {webpack 4, webpack 5}
  • gatsby
  • vite
  • esbuild
  • snowpack
  • electron? will investigate later. focusing on the web first

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 19, 2020

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 23aa90d

@vercel

This comment has been minimized.

@eps1lon
Copy link
Member Author

eps1lon commented May 17, 2021

No longer pursuing manually written commonJS code. The goal is to ship only ES modules anyway so require would no longer be possible anyway. Instead we assume you always have some kind of bunlder/meta framework to consume import statements. So if you need to require you can always transpile our shipped code to commonJS modules.

@eps1lon eps1lon marked this pull request as ready for review May 20, 2021 12:43
@eps1lon eps1lon merged commit 363bbbf into mui:next Jun 1, 2021
@eps1lon eps1lon deleted the test/bundle-fixtures branch June 1, 2021 06:25
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks great, but I have noticed that a growing number of PRs have been landing on HEAD unreviewed.

What do you think about asking for peer reviews and waiting for one peer review before moving forward with nontrivial changes (if no reviews move forward anyway after a reasonable amount of time)? It would help share knowledge.

test/bundling/README.md Show resolved Hide resolved
test/bundling/fixtures/vite/vite.config.js Show resolved Hide resolved
@eps1lon
Copy link
Member Author

eps1lon commented Jun 2, 2021

The change looks great, but I have noticed that a growing number of PRs have been landing on HEAD unreviewed.

Please refer to the last meeting where we explicitly taked about this and you even said you're doing less. Could you be honest about what changed in the last days?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 2, 2021

@eps1lon Sorry, I wasn't clear. In my previous message, I was proposing that we have a peer review from another member of the team. I didn't mean coming from me :)

My aim is to not be the peer review but to only leave comments where I see potential opportunities. I hope it clarifies it and is sound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants