-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Add bundle fixtures #23166
[test] Add bundle fixtures #23166
Conversation
8248699
to
0b3f66d
Compare
This comment has been minimized.
This comment has been minimized.
No longer pursuing manually written commonJS code. The goal is to ship only ES modules anyway so |
bugged in yarn v1 therefore using yarn v2
aa993e0
to
745fef3
Compare
3f2061a
to
cacc9d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks great, but I have noticed that a growing number of PRs have been landing on HEAD unreviewed.
What do you think about asking for peer reviews and waiting for one peer review before moving forward with nontrivial changes (if no reviews move forward anyway after a reasonable amount of time)? It would help share knowledge.
Please refer to the last meeting where we explicitly taked about this and you even said you're doing less. Could you be honest about what changed in the last days? |
@eps1lon Sorry, I wasn't clear. In my previous message, I was proposing that we have a peer review from another member of the team. I didn't mean coming from me :) My aim is to not be the peer review but to only leave comments where I see potential opportunities. I hope it clarifies it and is sound. |
Act as a smoke test for the bundle layout.
Example run: https://app.circleci.com/pipelines/github/mui-org/material-ui/42820/workflows/210cfd58-b66f-4c3e-a3a5-4e9c00681603
TODO:
electron?will investigate later. focusing on the web first