[Portal] Migrate to unstyled

[povilass]

• I have followed (at least) the PR section of the contributing guide.

Task by #24857 request.

[mui-pr-bot]

@material-ui/unstyled: parsed: +2.70% , gzip: +2.51%

Details of bundle changes

Generated by 🚫 dangerJS against e892d03

[oliviertassinari]

I don't think that Portal should be prefixed with unstyled, as by definition, there are no styled version of it.

I think that the solution should be about moving the source from @material-ui/core to @material-ui/unstyled while reexporting the component in the core. The diff should be in the order of magnitude of +10/-10 LOCs.

[povilass]

Got it

[povilass]

@oliviertassinari I left export from @material-ui/core/Portal if I remove it it will be breaking change.

[eps1lon]

Shouldn't this be done by babel-plugin-module-resolver?

[oliviertassinari]

It also seems to work with:

diff --git a/babel.config.js b/babel.config.js
index 658f4724f9..f2a14b0472 100644
--- a/babel.config.js
+++ b/babel.config.js
@@ -132,6 +132,19 @@ module.exports = function getBabelConfig(api) {
           ],
         ],
       },
+      rollup: {
+        plugins: [
+          [
+            'babel-plugin-module-resolver',
+            {
+              root: ['./'],
+              alias: {
+                '@material-ui/unstyled': path.resolve(__dirname, './packages/material-ui-unstyled/src'),
+              },
+            },
+          ],
+        ],
+      },
       benchmark: {
         plugins: [
           ...productionPlugins,
diff --git a/packages/material-ui/package.json b/packages/material-ui/package.json
index fad598de19..2b67f5fdcf 100644
--- a/packages/material-ui/package.json
+++ b/packages/material-ui/package.json
@@ -31,7 +31,7 @@
     "build:modern": "node ../../scripts/build modern",
     "build:node": "node ../../scripts/build node",
     "build:stable": "node ../../scripts/build stable",
-    "build:umd": "cross-env BABEL_ENV=stable rollup -c scripts/rollup.config.js",
+    "build:umd": "cross-env BABEL_ENV=rollup rollup -c scripts/rollup.config.js",
     "build:copy-files": "node ../../scripts/copy-files.js",
     "build:types": "node ../../scripts/buildTypes",
     "extract-error-codes": "cross-env MUI_EXTRACT_ERROR_CODES=true yarn build:modern",
diff --git a/packages/material-ui/scripts/rollup.config.js b/packages/material-ui/scripts/rollup.config.js
index 8112288071..19460964f1 100644
--- a/packages/material-ui/scripts/rollup.config.js
+++ b/packages/material-ui/scripts/rollup.config.js
@@ -94,7 +94,7 @@ export default [
     external: Object.keys(globals),
     plugins: [
       nodeResolve(nodeOptions),
-      nestedFolder,
+      // nestedFolder,
       babel(babelOptions),
       commonjs(commonjsOptions),
       nodeGlobals(), // Wait for https://github.com/cssinjs/jss/pull/893

A preference?

[eps1lon]

Fine for now. I'll improve it in a follow-up. Our babel config already has all the relevant information. We just need to reconcile it with the rollup externals.

[oliviertassinari]

@povilass Alright, one item done :)