-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system] Add boxSizing to sizing styled system #19684
Conversation
Details of bundle changes.Comparing: e41ecf0...8896fc3
|
@mesteche Have you considered to set box-sizing globally to |
@oliviertassinari Yes, but when trying to integrate React + Material-ui + some other lib in a legacy codebase with custom global css and some relative/absolute positionning, being able to control the box model on a per component basis is a must to avoid breaking anything existing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
On a similar topic, I'm wondering, would #19669 has the potential to help you too?
Now that you mention it, it would indeed help us keep the react parts of our app cleaner. |
@mesteche Thanks |
This PR would make the css property
box-sizing
part of thesyzing
system.This would allow users to customize the box model of their components more easily, turning this:
into this: