[ScopedCssBaseline] Allow css to be only applied on children #19669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 9f54e27...28f3506
|
|
I'm not sure why the |
TomPradat
changed the title
oliviertassinari
previously requested changes
Feb 12, 2020
There was a problem hiding this comment.
It's a great start, thanks for working on it.
However, I think that we will need to change the strategy. The scopeToChildren prop fundamentally changes the structure of the component. This turns into a couple of problems: forward ref that won't always work, prop spreading conflict with the exact prop types, style hook that won't be possible with styled components migration.
In this case, I think that we should go with a new component. What about ScopedCssBaseline?
|
Note 1. We might want to use withStyles over the hook to fix #17244, now is a good opportunity. |
oliviertassinari
added
PR: needs revision
oliviertassinari
force-pushed
the
feature/cssbaseline-isolation
branch
from
405fffa
to
889e753
Compare
oliviertassinari
removed
the
PR: needs revision
oliviertassinari
force-pushed
the
feature/cssbaseline-isolation
branch
from
889e753
to
968ef44
Compare
|
I think the title or the description should mention that a new component has been added. |
oliviertassinari
changed the title
|
@joshwooding thanks for the tip |
This was referenced Mar 10, 2020
This was referenced Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19657
Fixes #17244