[DatePicker] Drastically improve perf #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,8 +5,9 @@ const AppRoutes = require('./app-routes.jsx'); | |||
| const injectTapEventPlugin = require('react-tap-event-plugin'); | |||
| const createHistory = require('history/lib/createHashHistory'); | |||
|
|
|||
| //Needed for React Developer Tools | |||
|
@shaurya947 Any thougs? |
| window.React = React; | ||
| window.Perf = require('react/lib/ReactDefaultPerf'); |
There was a problem hiding this comment.
Hum, I should use require('react-addons-perf').
|
nice! |
|
@oliviertassinari just tried out this branch, I do notice considerable improvement. Feel free to merge this! Good work 👍 |
oliviertassinari
added a commit
that referenced
this pull request
Oct 20, 2015
[DatePicker] Drastically improve perf
zannager
added
component: date picker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1899. I think that there is still room for improving perf on this component.
A benchmark when openning the DatePicker
Befor
After
