Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date-Picker slow performance #18

Closed
funkybunky opened this issue Nov 2, 2015 · 5 comments
Closed

Date-Picker slow performance #18

funkybunky opened this issue Nov 2, 2015 · 5 comments

Comments

@funkybunky
Copy link

After opening the modal of FormsyDate, there is a ~1s delay until the date-picker becomes responsive.
Also after clicking on a date, there is another ~1s delay until the corresponding date gets shown as text in modal header (example: clicking on 13, wait, "Fri,Nov 13" is shown in the header)
Any ideas what could cause these delays/ performance issues?

@mbrookes
Copy link
Collaborator

mbrookes commented Nov 2, 2015

How well does the Material-UI date picker perform on the same system outside of Formsy / fmui? The date picker is slow, but not that slow! Try setting an explicit date range.

@funkybunky
Copy link
Author

I set the date range smaller (14months) and the picker now performs quite well. Thanks!
If you accept it, I would make a PR and add it to the readme (perhaps under "Known Issues"?) and even update the example code accordingly. Are you okay with that?

@mbrookes
Copy link
Collaborator

mbrookes commented Nov 2, 2015

Well, it isn't an issue with formsy-material-ui per-se, so not sure it belongs in issues, but it would be a good idea to update the example since this is an undocumented best practice for Material-UI, and a code comment could highlight the issue. You might like to update the Material-UI docs too! 😉

@funkybunky
Copy link
Author

Given the perf fixes from mui/material-ui#1905, should we still update the examples to include a reduced date-range? I had the impression that it doesn't affect it noticeably with this perf fix in place.

@mbrookes
Copy link
Collaborator

mbrookes commented Nov 3, 2015

No, lets leave the example as is. Glad you go it resolved.

@mbrookes mbrookes closed this as completed Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants