[TablePagination] Allow more rows per pages

[oliviertassinari]

I'm not sure to what extent this change is breaking. Google is allowing a lot of rows. I think that 50 isn't too much to ask for.

Google Search Console

[oliviertassinari]

@fzaninotto Any comment here? From my experience using react-admin, I often end-up adding &perPage=100 in the URL:

[prathe]

@oliviertassinari

A higher maximum of rows per page, such as 500 can be very practical in many cases. But as a default value, it may be safer to prevent setting high numbers.

I'm not convinced that [5,10,25] or [5,10,25,50] are either a good default value. Relatively close numbers such as 5 and 10 may not be relevant choices in many cases, a user could just hit the next page instead. So [10, 50] could be better? Note that this would change the rows per page to 10.

Also, I just can't understand why 5 is a default value. It seems that 10 or 20 would be more realistic.

The problem I see is when rowsPerPage has been set, let's say to 20, and rowsPerPageOptions has the default value of [5,10,25]. It may be confusing for a user.

Maybe a better default could be not to display the Rows per page control? A default rowsPerPage would then need to be decided.

Would those be more sensible defaults?
rowsPerPageOptions=[]
rowsPerPage=10

[fzaninotto]

This won't be a breaking change for react-admin, as the [5, 10, 25] list of options is in our Pagination's `defaultProps.

I'm +1 for that change!

[oliviertassinari]

Thanks for the feedback guys, I'm going with 10 as the default value and [10, 25, 50, 100] as the possible values. We will release the change in a minor, it's too sensitive for a patch.

[prathe]

Good! Let's try it.

[phacks]

@oliviertassinari Hi! I think the move of ...TablePaginationActions/TablePaginationActions.js → TablePagination/TablePaginationActions.js may be a breaking change, at least for ReactAdmin.

Indeed, this import in react-admin has to be changed to the following for a migration to v3.5.1 (see marmelab/react-admin#2399 (comment) for context):

- import TablePaginationActions from '@material-ui/core/TablePaginationActions';
+ import TablePaginationActions from '@material-ui/core/TablePagination/TablePaginationActions';

I don’t know whether that problem can appear in other codebases, however it may be prudent to include it in the changelog for v3.5.1?

[oliviertassinari]

@phacks Salut Nicolas, ça fait longtemps, the component is considered private, it's not documented:
https://github.com/mui-org/material-ui/blob/7493951fe7a42ff95ce8cf89088da604a88c6e4e/packages/material-ui/src/TablePagination/TablePaginationActions.js#L9

[phacks]

@oliviertassinari Hello Olivier ! En effet, et bravo pour tout ce que tu as fait sur material-ui !

J'ai poussé une PR sur React Admin pour enlever la dépendance à TablePaginationActions, qui n'était pas si utile. Merci pour ton aide :)