[#2399] chore: hardcode TablePaginationAction proptypes #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacks
force-pushed
the
2399-hardcode-tablepaginationaction-proptypes
branch
from
35e494e to
648081f
Compare
fzaninotto
approved these changes
Nov 21, 2018
The import ``` import TablePaginationActions from '@material-ui/core/TablePaginationActions'; ``` does not work anymore in material-ui’s more recent versions, as per mui/material-ui#13524. This commit makes transitioning from `[email protected]` to `3.5.1` easier.
phacks
force-pushed
the
2399-hardcode-tablepaginationaction-proptypes
branch
from
648081f to
46eaf60
Compare
|
weird, some tests are failing which are not related to your PR. But it seems you definitely broke one test. |
|
Looks like I forgot to Tests are all good now. |
djhi
approved these changes
Nov 21, 2018
fzaninotto
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2399 for context.
The import
does not work anymore in material-ui’s more recent versions, as per
mui/material-ui#13524.
This commit makes transitioning from
[email protected]to[email protected]easier.